Skip to content

feat: modify workflow actions to remove icu-config-removal #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rolaxgar97 wants to merge 8 commits into
base: release/v2.4.9.0
Choose a base branch
from
Open

feat: modify workflow actions to remove icu-config-removal #635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
afc254e
feat: modify build-debian11 action from github workflow
Rolaxgar97 Aug 24, 2026
3a7741a
feat: modify build-debian12 and Ubuntu 20 action from github workflow
Rolaxgar97 Aug 24, 2026
de0187f
chore: return previous Ubuntu 20 action version
Rolaxgar97 Aug 24, 2026
d09c903
feat: Ubuntu 20 action from github workflow
Rolaxgar97 Aug 24, 2026
fabd626
Fix: pass pkgdata.inc path directly to pkgdata via -O
Rolaxgar97 Aug 24, 2026
cbf86d1
chore: pass pkgdata.inc path explicitly to pkgdata for Ubuntu
Rolaxgar97 Aug 24, 2026
a534cc4
chore: pass pkgdata.inc path via -O only when available
Rolaxgar97 Aug 24, 2026
45b39c5
feat: resolve pkgdata.inc path via pkg-config instead of icu-config
Rolaxgar97 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-debian11.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
submodules: recursive
- name: Build LTFS
id: build
uses: LinearTapeFileSystem/Debian11-Build@v1.1.1
uses: LinearTapeFileSystem/Debian11-Build@release/test-icu-config-removal
with:
destination: '/tmp/ltfs'
submodules: recursive
2 changes: 1 addition & 1 deletion .github/workflows/build-debian12.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
submodules: recursive
- name: Build LTFS
id: build
uses: LinearTapeFileSystem/Debian12-Build@v1.0
uses: LinearTapeFileSystem/Debian12-Build@fix/issue-628
with:
destination: '/tmp/ltfs'
submodules: recursive
2 changes: 1 addition & 1 deletion .github/workflows/build-ubuntu-focal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ jobs:
submodules: recursive
- name: Build LTFS
id: build
uses: LinearTapeFileSystem/Ubuntu2004-Build@v1.1
uses: LinearTapeFileSystem/Ubuntu2004-Build@fix/issue-628
with:
destination: '/tmp/ltfs'
8 changes: 7 additions & 1 deletion messages/make_message_src.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ else
else
PKGDATA=pkgdata
fi
if pkg-config --exists icu-uc 2>/dev/null; then
_ICU_LIBDIR=$(pkg-config --variable=libdir icu-uc 2>/dev/null)
if [ -f "${_ICU_LIBDIR}/icu/pkgdata.inc" ]; then
ICU_PKGDATA_INC="${_ICU_LIBDIR}/icu/pkgdata.inc"
fi
fi
fi

if [ "$#" -ne "1" ]; then
Expand Down Expand Up @@ -61,7 +67,7 @@ make_obj() {
${GENRB} -d work -q *.txt
cd work
ls *.res >packagelist.txt
${PKGDATA} -p ${BASENAME} -m static -q packagelist.txt >/dev/null
${PKGDATA} ${ICU_PKGDATA_INC:+-O} ${ICU_PKGDATA_INC} -p ${BASENAME} -m static -q packagelist.txt >/dev/null

case $KERNEL_NAME in
MINGW32_NT*)
Expand Down
Loading