fix: eliminate silent data loss in review pipeline and align docs - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three correctness bugs that silently dropped data or misreported failures, plus aligns stale docs.
Changes
internal/prompt/builder.go):hunkTrimsilently cut each file's diff at 6000 bytes (~150-200 lines), contradicting the 800-line chunking and dropping the tail of large files. Diffs are now bounded only by ~800-line chunking and the 32 KB prompt cap.PRDiff(internal/github/client.go): non-200 responses (e.g. 404/500) were read as diff text and misreported as "success, 0 issues". Now returns an error.internal/reviewer/reviewer.go): a chunk whose LLM output failed to parse was silently skipped, producing a review with missing coverage. Now the whole review fails instead.README.md,README.zh-CN.md): remove the now-inaccurate "oversized hunks trimmed before construction" claim.Testing
go test ./...not run locally (no Go toolchain on this machine). Changes are small and localized; CI / localgo test ./...recommended.