Repository navigation
V21: Let the Docker image start on a fresh named volume - #687
Merged
Merged
Conversation
Create and chown /app/data before USER node and declare it a VOLUME. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LinuxDevil
force-pushed
the
v21-docker-data-volume
branch
from
October 19, 2026 22:59
3aeef85 to
c88a38f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes audit finding OPS-3 (Vercel competitor audit, 2026-10-19).
What was wrong
The generated image runs as
node, butdocker run -v lousho-data:/app/data -e LOUSHO_STORE=sqlite:/app/data/lousho.dbmounted a root-owned fresh volume, so the server failed withunable to open database file.What changed
RUN mkdir -p /app/data && chown node:node /app/datathenVOLUME /app/data, both beforeUSER node(Docker copies the image dir's ownership into a new named volume).-v lousho-data:/app/data+LOUSHO_STORE=sqlite:/app/data/lousho.dbexample; llms-full.txt regenerated.Tests
USER nodeandVOLUME /app/data(failed before the fix, passes after).npm run fallowcould not run locally.Changelog: Docker image now creates and chowns /app/data (declared a VOLUME) so a fresh named volume works with LOUSHO_STORE=sqlite:/app/data/...
🤖 Generated with Claude Code