Skip to content

feat: coerce numeric types in WidgetFactory.fromTemplate #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricalBoy wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: coerce numeric types in WidgetFactory.fromTemplate #7671

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1436d62
change load order
ElectricalBoy Jun 17, 2026
4a6407e
do input integrity check earlier
ElectricalBoy Jun 17, 2026
11176d1
coerce numeric types
ElectricalBoy Jun 17, 2026
cf28a32
update type annotation
ElectricalBoy Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lua/wikis/commons/Widget/Factory.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,23 @@
local Lua = require('Module:Lua')

local Class = Lua.import('Module:Class')
local String = Lua.import('Module:StringUtils')
local Table = Lua.import('Module:Table')

local WidgetFactory = {}

---@param args {widget: string, children: Renderable|Renderable[], [any]:any}
---@return Widget
---@param args {widget: string, [any]: any}
---@return Widget|VNode
function WidgetFactory.fromTemplate(args)
local copiedArgs = Table.copy(args)
local widgetClass = Table.extract(copiedArgs, 'widget')
copiedArgs.children = type(copiedArgs.children) == 'table' and copiedArgs.children or {copiedArgs.children}
Comment thread
hjpalpha marked this conversation as resolved.
local widgetClass = Table.extract(args, 'widget')
assert(String.isNotEmpty(widgetClass), 'WidgetFactory: widget must be specified')
local WidgetClass = Lua.import('Module:Widget/' .. widgetClass)
local copiedArgs = Table.mapValues(args, function (arg)
if type(arg) == 'table' then
return arg
end
return tonumber(arg) or arg
end)
return WidgetClass(copiedArgs)
end

Expand Down
Loading