Skip to content

fix(match2): match summaries with bracket reset overflow popup height #7683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricalBoy wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(match2): match summaries with bracket reset overflow popup height #7683

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff9c8ba
fix height
ElectricalBoy Jun 22, 2026
622403f
remove gap between breakpoints
ElectricalBoy Jun 22, 2026
9af3962
adjust color scheme
ElectricalBoy Jun 22, 2026
3ad3156
refactor
ElectricalBoy Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions stylesheets/commons/Brackets.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,22 @@
justify-content: flex-start;
flex-wrap: unset;
gap: 0.5rem;

.theme--dark & {
color-scheme: dark;
}

.toggle-area & {
max-height: calc( 100dvh - ( 2.75rem + 4.1875rem + 3.5rem ) ); // 3.5rem for the switcher (compared to .brkts-popup.brkts-match-info-popup)

@mbergen mbergen Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add a comment to explain what the other deductions are for?

@hjpalpha hjpalpha Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are copied from .brkts-popup.brkts-match-info-popup :P

}

@media ( width > 768px ) {
max-height: 65vh;

.toggle-area & {
max-height: calc( 65vh - 3.5rem ); // 3.5rem for the switcher
}
}
}

.theme--light & {
Expand All @@ -554,10 +570,6 @@
border-color: var( --clr-on-surface-dark-primary-8 );
}

@media ( min-width: 769px ) {
max-height: 65vh;
}

.timer-object-date {
display: block;
}
Expand Down
Loading