Skip to content

feat(TeamParticipants): Do not always display first role as icon #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hjpalpha wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(TeamParticipants): Do not always display first role as icon #7684

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b90a301
feat(TeamParticipants): Do not always display first role as icon
hjpalpha Jun 22, 2026
4140e12
as per review
hjpalpha Jun 22, 2026
9aa0a38
chore: update visual snapshots
hjpalpha Jun 22, 2026
5003b6c
Merge branch 'role-icon-adjust-for-TP' of https://github.com/Liquiped…
hjpalpha Jun 22, 2026
99c5e09
chore: update visual snapshots
hjpalpha Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lua/wikis/commons/Widget/Participants/Team/Roster.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,19 +54,14 @@ end
-- * If there's a non-ingame role assigned, display it after the status
-- * Returns an array of labels to display (can be multiple)
-- * Left-role:
-- * If the first role has an icon, we use that to render the left-role
-- * If not then we instead display the icon of the first ingame role with icon
-- * Display the icon of the first ingame role with icon
---@param player table
---@return string?, string[]?
local function getRoleDisplays(player)
local roles = player.extradata.roles or {}
local played = player.extradata.played

local function roleLeftDisplay()
local firstRole = roles[1]
if firstRole and firstRole.icon then
return firstRole.icon
end
for _, role in ipairs(roles) do
if role.type == RoleUtil.ROLE_TYPE.INGAME and role.icon then
return role.icon
Expand Down