refactor: cleanup match ticker step 1#7692
Draft
Rathoz wants to merge 3 commits into
Draft
Conversation
Collaborator
Collaborator
Author
|
Accpectable imo, it's handled cleanly |
hjpalpha
reviewed
Jun 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MatchTicker rendering pipeline to remove legacy display component modules and standardize output on Widget3-based match cards, with entity pages using a carousel-style (“entityStyle”) layout.
Changes:
- Default MatchTicker usage to the new match card style and remove the legacy
MatchTicker/DisplayComponents*modules. - Move entity-style (carousel) rendering into
MatchTicker:create()and update infobox/entity integrations to call:query():create()directly. - Update main-page ticker wiring to call
MatchTicker/Custom.mainPageby default.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/wikis/commons/Widget/Match/Ticker/Container.lua | Switch default invoked function to MatchTicker/Custom.mainPage. |
| lua/wikis/commons/MatchTicker/DisplayComponents/New.lua | Deleted (new style now handled directly in MatchTicker). |
| lua/wikis/commons/MatchTicker/DisplayComponents/Entity.lua | Deleted (entity/carousel layout moved into MatchTicker:create()). |
| lua/wikis/commons/MatchTicker/DisplayComponents.lua | Deleted (legacy display layer removed). |
| lua/wikis/commons/MatchTicker/Custom.lua | Remove old entrypoints, make mainPage the canonical entry, and update recent header to Widget3 infobox header. |
| lua/wikis/commons/MatchTicker.lua | Centralize rendering using Widget3 HTML + MatchCard; add horizontal (carousel) layout path. |
| lua/wikis/commons/Infobox/UnofficialWorldChampion.lua | Use MatchTicker{entityStyle=true}:query():create() instead of manual entity container assembly. |
| lua/wikis/commons/Infobox/Team.lua | Same: migrate upcoming matches rendering to :query():create() with entityStyle=true. |
| lua/wikis/commons/Infobox/Person.lua | Same: migrate upcoming matches rendering to :query():create() with entityStyle=true. |
| lua/wikis/commons/Infobox/League.lua | Same: migrate upcoming matches rendering to :query():create() with entityStyle=true. |
| lua/wikis/commons/HiddenDataBox.lua | Same: migrate match ticker rendering to :query():create() with entityStyle=true and remove old entity display import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hjpalpha
reviewed
Jun 24, 2026
Comment on lines
61
to
64
| children = { | ||
| Header._createInfoboxButtons(), | ||
| Header._createInfoboxButtons(props), | ||
| props.name, | ||
| } |
Collaborator
There was a problem hiding this comment.
need to use WidgetUtil.collect else it throws
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
How did you test this change?