Skip to content

refactor: cleanup match ticker step 1#7692

Draft
Rathoz wants to merge 3 commits into
mainfrom
cleanup-matchticker-1
Draft

refactor: cleanup match ticker step 1#7692
Rathoz wants to merge 3 commits into
mainfrom
cleanup-matchticker-1

Conversation

@Rathoz

@Rathoz Rathoz commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Improve entity pages ticker setup
  • Remove the oldest match ticker style
  • Default to "new" style (main page style)
  • Removed the 2 remaining "MatchTicker/DisplayComponents" by refactoring
  • Removed mw.html usage (in favor of Widget3)

How did you test this change?

@hjpalpha

Copy link
Copy Markdown
Collaborator

fwiw:
we get the overflow issue for the names
especially on craft wikis due to the additional faction display
image

@Rathoz

Rathoz commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

Accpectable imo, it's handled cleanly

Comment thread lua/wikis/commons/MatchTicker/Custom.lua Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the MatchTicker rendering pipeline to remove legacy display component modules and standardize output on Widget3-based match cards, with entity pages using a carousel-style (“entityStyle”) layout.

Changes:

  • Default MatchTicker usage to the new match card style and remove the legacy MatchTicker/DisplayComponents* modules.
  • Move entity-style (carousel) rendering into MatchTicker:create() and update infobox/entity integrations to call :query():create() directly.
  • Update main-page ticker wiring to call MatchTicker/Custom.mainPage by default.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lua/wikis/commons/Widget/Match/Ticker/Container.lua Switch default invoked function to MatchTicker/Custom.mainPage.
lua/wikis/commons/MatchTicker/DisplayComponents/New.lua Deleted (new style now handled directly in MatchTicker).
lua/wikis/commons/MatchTicker/DisplayComponents/Entity.lua Deleted (entity/carousel layout moved into MatchTicker:create()).
lua/wikis/commons/MatchTicker/DisplayComponents.lua Deleted (legacy display layer removed).
lua/wikis/commons/MatchTicker/Custom.lua Remove old entrypoints, make mainPage the canonical entry, and update recent header to Widget3 infobox header.
lua/wikis/commons/MatchTicker.lua Centralize rendering using Widget3 HTML + MatchCard; add horizontal (carousel) layout path.
lua/wikis/commons/Infobox/UnofficialWorldChampion.lua Use MatchTicker{entityStyle=true}:query():create() instead of manual entity container assembly.
lua/wikis/commons/Infobox/Team.lua Same: migrate upcoming matches rendering to :query():create() with entityStyle=true.
lua/wikis/commons/Infobox/Person.lua Same: migrate upcoming matches rendering to :query():create() with entityStyle=true.
lua/wikis/commons/Infobox/League.lua Same: migrate upcoming matches rendering to :query():create() with entityStyle=true.
lua/wikis/commons/HiddenDataBox.lua Same: migrate match ticker rendering to :query():create() with entityStyle=true and remove old entity display import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lua/wikis/commons/MatchTicker.lua Outdated
Comment thread lua/wikis/commons/MatchTicker/Custom.lua Outdated
Comment on lines 61 to 64
children = {
Header._createInfoboxButtons(),
Header._createInfoboxButtons(props),
props.name,
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to use WidgetUtil.collect else it throws

@ElectricalBoy ElectricalBoy added the c: match_ticker match2 based match ticker label Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: match_ticker match2 based match ticker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants