Skip to content

refactor: cleanup match ticker step 2 #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rathoz wants to merge 4 commits into
base: cleanup-matchticker-1
Choose a base branch
from
+385 −335
Draft

refactor: cleanup match ticker step 2 #7693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc191f0
refactor: further match ticker cleanup
Rathoz Jun 24, 2026
3735bd5
fix entry point
Rathoz Jun 24, 2026
af00947
readd unintended deleted logic
Rathoz Jun 24, 2026
c3940da
lint
Rathoz Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/wikis/ageofempires/Infobox/Person/Player/Custom.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function CustomInjector:parse(id, widgets)
return widgets
end

---@return Html?
---@return Renderable?
function CustomPlayer:createBottomContent()
return MatchTicker.recent{player = self.pagename}
end
Expand Down
2 changes: 1 addition & 1 deletion lua/wikis/brawlstars/Infobox/Person/Player/Custom.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function CustomPlayer:adjustLPDB(lpdbData, args)
return lpdbData
end

---@return Widget?
---@return Renderable?
function CustomPlayer:createBottomContent()
if self:shouldStoreData(self.args) and String.isNotEmpty(self.args.team) then
local teamPage = TeamTemplate.getPageName(self.args.team)
Expand Down
5 changes: 2 additions & 3 deletions lua/wikis/commons/HiddenDataBox.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ local Logic = Lua.import('Module:Logic')
local Game = Lua.import('Module:Game')
local I18n = Lua.import('Module:I18n')
local Info = Lua.import('Module:Info', {loadData = true})
local MatchTicker = Lua.import('Module:MatchTicker')
local MatchTicker = Lua.import('Module:MatchTicker/Controller')
local Namespace = Lua.import('Module:Namespace')
local ReferenceCleaner = Lua.import('Module:ReferenceCleaner')
local String = Lua.import('Module:StringUtils')
Expand Down Expand Up @@ -230,7 +230,7 @@ function HiddenDataBox._matchTicker(supressMatchTicker)

return Logic.tryCatch(
function()
local matchTicker = MatchTicker{
return MatchTicker.makeMatchTicker{
tournament = mw.title.getCurrentTitle().prefixedText,
limit = 5,
upcoming = true,
Expand All @@ -239,7 +239,6 @@ function HiddenDataBox._matchTicker(supressMatchTicker)
queryByParent = false,
entityStyle = true,
}
return matchTicker:query():create()
end,
function()
return nil
Expand Down
5 changes: 2 additions & 3 deletions lua/wikis/commons/Infobox/League.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ local Links = Lua.import('Module:Links')
local Locale = Lua.import('Module:Locale')
local Logic = Lua.import('Module:Logic')
local Lpdb = Lua.import('Module:Lpdb')
local MatchTicker = Lua.import('Module:MatchTicker')
local MatchTicker = Lua.import('Module:MatchTicker/Controller')
local MetadataGenerator = Lua.import('Module:MetadataGenerator')
local Namespace = Lua.import('Module:Namespace')
local Page = Lua.import('Module:Page')
Expand Down Expand Up @@ -357,7 +357,7 @@ function League:_createUpcomingMatches()

return Logic.tryCatch(
function()
local matchTicker = MatchTicker{
return MatchTicker.makeMatchTicker{
tournament = self.pagename,
limit = 5,
upcoming = true,
Expand All @@ -366,7 +366,6 @@ function League:_createUpcomingMatches()
queryByParent = true,
entityStyle = true,
}
return matchTicker:query():create()
end,
function()
return nil
Expand Down
5 changes: 2 additions & 3 deletions lua/wikis/commons/Infobox/Person.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ local BasicInfobox = Lua.import('Module:Infobox/Basic')
local Earnings = Lua.import('Module:Earnings')
local Flags = Lua.import('Module:Flags')
local Links = Lua.import('Module:Links')
local MatchTicker = Lua.import('Module:MatchTicker')
local MatchTicker = Lua.import('Module:MatchTicker/Controller')
local PlayerIntroduction = Lua.import('Module:PlayerIntroduction/Custom')
local Region = Lua.import('Module:Region')

Expand Down Expand Up @@ -212,15 +212,14 @@ function Person:_createUpcomingMatches()

return Logic.tryCatch(
function()
local matchTicker = MatchTicker{
return MatchTicker.makeMatchTicker{
player = self.pagename,
limit = 5,
upcoming = true,
ongoing = true,
hideTournament = false,
entityStyle = true,
}
return matchTicker:query():create()
end,
function()
return nil
Expand Down
5 changes: 2 additions & 3 deletions lua/wikis/commons/Infobox/Team.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ local Json = Lua.import('Module:Json')
local Logic = Lua.import('Module:Logic')
local Lpdb = Lua.import('Module:Lpdb')
local Namespace = Lua.import('Module:Namespace')
local MatchTicker = Lua.import('Module:MatchTicker')
local MatchTicker = Lua.import('Module:MatchTicker/Controller')
local String = Lua.import('Module:StringUtils')
local Table = Lua.import('Module:Table')
local TeamTemplate = Lua.import('Module:TeamTemplate')
Expand Down Expand Up @@ -310,15 +310,14 @@ function Team:_createUpcomingMatches()

return Logic.tryCatch(
function()
local matchTicker = MatchTicker{
return MatchTicker.makeMatchTicker{
team = self.pagename,
limit = 5,
upcoming = true,
ongoing = true,
hideTournament = false,
entityStyle = true,
}
return matchTicker:query():create()
end,
function()
return nil
Expand Down
5 changes: 2 additions & 3 deletions lua/wikis/commons/Infobox/UnofficialWorldChampion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ local Info = Lua.import('Module:Info', {loadData = true})
local Json = Lua.import('Module:Json')
local Logic = Lua.import('Module:Logic')
local Lpdb = Lua.import('Module:Lpdb')
local MatchTicker = Lua.import('Module:MatchTicker')
local MatchTicker = Lua.import('Module:MatchTicker/Controller')
local Namespace = Lua.import('Module:Namespace')
local String = Lua.import('Module:StringUtils')
local Table = Lua.import('Module:Table')
Expand Down Expand Up @@ -216,15 +216,14 @@ function UnofficialWorldChampion:_createUpcomingMatches()

return Logic.tryCatch(
function()
local matchTicker = MatchTicker{
return MatchTicker.makeMatchTicker{
team = currentChampion.template,
limit = 5,
upcoming = true,
ongoing = true,
hideTournament = false,
entityStyle = true,
}
return matchTicker:query():create()
end,
function()
return nil
Expand Down
Loading