Skip to content

Fix/602: root folder deletion#607

Open
T4g1 wants to merge 2 commits into
Listenarrs:canaryfrom
T4g1:fix/602-root-folder-deletion
Open

Fix/602: root folder deletion#607
T4g1 wants to merge 2 commits into
Listenarrs:canaryfrom
T4g1:fix/602-root-folder-deletion

Conversation

@T4g1
Copy link
Copy Markdown
Contributor

@T4g1 T4g1 commented May 18, 2026

Summary

  • Fix [Bug] Unable to delete root folder #602
    When removing root folders that are contained within other root folders, audiobooks can be detected as using both of them.
    I fixed that issue by making it count the amount of root folders associated with each audiobooks and allowing the deletion only if none of them is orphaned from all root folders

Testing

  • Reworked the root folders tests and added two tests to prevent regression and validate the behavior

Notes

  • Some other areas of the root folder services assumes root folders are not contained within each other, we might want to create an issue to investigate the behavior regarding those and decide if we want to prevent that use case or not

@T4g1 T4g1 self-assigned this May 18, 2026
@T4g1 T4g1 requested a review from a team May 18, 2026 13:10
@T4g1 T4g1 added the patch patch version bump - backward compatible bug fixes label May 18, 2026
@T4g1 T4g1 requested a review from therobbiedavis May 21, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch patch version bump - backward compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Unable to delete root folder

1 participant