Fix Run Editor Cell Editing - #1163
Merged
Merged
Conversation
Run Editor time fields store their unparsed text in shared row-local state and commit it when focus leaves the input. Modifier-aware row selection now runs on mouse-down, which changes the active segment and clears that draft before the browser delivers the corresponding blur event. Commit the focused input before changing segment or group selection so clicking the same cell, another cell, another row, or a group header applies the edit to the segment that owns it. Restore focus after modifier-based deselection to preserve existing Ctrl and Command selection behavior. Move the shared row draft and parsing helpers into a focused module so the segment table remains responsible for interaction and rendering. Closes LiveSplit#1161
CryZe
added
enhancement
CryZe
enabled auto-merge (squash)
August 30, 2026 20:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Editor time fields store their unparsed text in shared row-local state and commit it when focus leaves the input. Modifier-aware row selection now runs on mouse-down, which changes the active segment and clears that draft before the browser delivers the corresponding blur event.
Commit the focused input before changing segment or group selection so clicking the same cell, another cell, another row, or a group header applies the edit to the segment that owns it. Restore focus after modifier-based deselection to preserve existing Ctrl and Command selection behavior.
Move the shared row draft and parsing helpers into a focused module so the segment table remains responsible for interaction and rendering.
Closes #1161