Skip to content

build(macOS): sign only valid framework bundles - #5484

Merged
ReenigneArcher merged 1 commit into
masterfrom
build/macos/fix-signing
Aug 7, 2026
Merged

build(macOS): sign only valid framework bundles#5484
ReenigneArcher merged 1 commit into
masterfrom
build/macos/fix-signing

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Aug 7, 2026

Copy link
Copy Markdown
Member

Description

#5483 did not fully resolve the signing issue on macOS builds. Confirmed this works by temporarily enabling signing for PR builds.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the build/macos/fix-signing branch from 5e2873c to 904fdbe Compare August 7, 2026 22:50
@ReenigneArcher
ReenigneArcher marked this pull request as ready for review August 7, 2026 22:52
@ReenigneArcher
ReenigneArcher merged commit 49e5697 into master Aug 7, 2026
31 of 38 checks passed
@ReenigneArcher
ReenigneArcher deleted the build/macos/fix-signing branch August 7, 2026 22:52
@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.79%. Comparing base (22f7a77) to head (904fdbe).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (22f7a77) and HEAD (904fdbe). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (22f7a77) HEAD (904fdbe)
Homebrew-ubuntu-24.04 1 0
Homebrew-macos-15 1 0
Homebrew-macos-14 1 0
Homebrew-macos-26 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5484      +/-   ##
==========================================
- Coverage   26.71%   17.79%   -8.93%     
==========================================
  Files         109      108       -1     
  Lines       24552    23750     -802     
  Branches    10764    10621     -143     
==========================================
- Hits         6559     4226    -2333     
- Misses      14848    15280     +432     
- Partials     3145     4244    +1099     
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-amd64 13.97% <ø> (ø)
Homebrew-macos-14 ?
Homebrew-macos-15 ?
Homebrew-macos-26 ?
Homebrew-ubuntu-24.04 ?
Linux-AppImage 13.31% <ø> (ø)
Windows-AMD64 17.29% <ø> (ø)
Windows-ARM64 14.95% <ø> (+0.01%) ⬆️
macOS-arm64 19.82% <ø> (?)
macOS-x86_64 20.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 82 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f7a77...904fdbe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant