Skip to content

fix GitHub Pages build - #21

Merged
LjyYano merged 1 commit into
masterfrom
codex/fix-pages-liquid
Aug 16, 2026
Merged

LjyYano merged 1 commit into
masterfrom
codex/fix-pages-liquid

Conversation

@LjyYano

@LjyYano LjyYano commented Aug 16, 2026

Copy link
Copy Markdown
Owner

What changed

  • split two compound where_exp expressions into Liquid 4-compatible chained filters
  • remove the unused README navigation Python script and its GitHub Actions workflow
  • remove obsolete README maintenance instructions and generated-region markers while keeping the current article navigation

Root cause

GitHub Pages uses Jekyll 3.10 with Liquid 4.0.4. Its where_exp parser accepts one comparison per expression, so the compound and expressions failed during the Pages build.

Validation

  • reproduced the original failure with Liquid 4.0.4 parsing rules
  • confirmed both replacement expressions parse successfully
  • checked the repository for remaining compound where_exp expressions and removed script references
  • git diff --check passes

@LjyYano
LjyYano marked this pull request as ready for review August 16, 2026 10:39
@LjyYano
LjyYano merged commit 7007e92 into master Aug 16, 2026
1 of 2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dac862aa93

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines -3 to -6
on:
push:
paths:
- "**/*.md"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve updates for the README article index

When a new article Markdown file is pushed, removing this trigger together with scripts/update_readme_nav.py leaves no repository-wide replacement that updates the static README navigation. The README still presents that section as “全部文章”/“完整文章导航”, so after the next article is added the repository front page will silently omit it; retain an update mechanism or stop presenting the retained static list as complete.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant