sd: build each source file separately#2188
Open
wbruna wants to merge 4 commits intoLostRuins:concedo_experimentalfrom
Open
sd: build each source file separately#2188wbruna wants to merge 4 commits intoLostRuins:concedo_experimentalfrom
wbruna wants to merge 4 commits intoLostRuins:concedo_experimentalfrom
Conversation
wbruna
force-pushed
the
kcpp_sd_split_build
branch
from
88a9fc3 to
515ff43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Makefile rules to build each sd .cpp source file separately, and create the corresponding object lists dynamically.
I've added an extra header to serve as a 'bridge' between sdtype_adapter.cpp and stable-diffusion.cpp internals, so the former now only depends on the public API and the extension functions. This way, all sd source files can be built without changes, and reused by the sdmain binary.
Additional sources will only need to be included in the appropriate source list (one for Koboldcpp, another for sdmain only). As an added benefit, the build should be faster now, since the individual sources are simpler than the bundle, and can be built in parallel.
This will likely conflict with #2184 , but rebasing should be fairly simple.