fix: Game Tracker truncating names containing dots#722
Open
ericreinsmidt wants to merge 1 commit into
Open
Conversation
cleanName() called removeExtension() on names already stored in the DB without extensions, causing names like "Gun.Smoke" to display as "Gun".
ericreinsmidt
force-pushed
the
fix/game-tracker-double-extension-strip
branch
from
e41d5d9 to
77aa9aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cleanName()calledremoveExtension()on game names already stored in the DB without file extensionsremoveExtension()call fromcleanName()This is an extremely rare case with ROMs released by No-Intro — Gun.Smoke (USA).nes may literally be the only one — but could come into play with homebrew games.
Test plan