fix: black screen when entry list is empty#723
Open
ericreinsmidt wants to merge 1 commit into
Open
Conversation
When Tools are disabled on a fresh install with no ROMs, the main list is empty but multiple code paths access entries without bounds checks. Added total>0 guards and null-safe patterns to prevent crashes and render a usable empty state instead of a black screen. Fixes LoveRetro#712
ericreinsmidt
force-pushed
the
fix/empty-list-black-screen
branch
from
6ff4579 to
44ea223
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
total>0guards and null-safe patterns to prevent crashes and render a usable empty stateFixes #712
Test plan