Skip to content

Replay a tab's tier write with checks at commit and fan out its whole effect (R92) - #169

Merged
LucaCappelletti94 merged 1 commit into
mainfrom
feat/r92-synced-references
Oct 18, 2026
Merged

LucaCappelletti94 merged 1 commit into
mainfrom
feat/r92-synced-references

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Owner

In the browser a tab's mirror holds only the tier rows its subscriptions cover and carries no references, so the worker's attached tier is the one enforcer. The relay hub now replays a tab's tier changeset with checks deferred to the commit, records what the worker actually changed through a session on the tier, cascades and SET NULL included, and fans that effect out to every tab reading a touched table. On the previous branch a cascade on the worker reached no tab, and a changeset listing a child before its parent was refused. A reference still broken at the commit rejects the mutation back to its author, and the worker's next write commits as usual.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.47%. Comparing base (b38250e) to head (6d57594).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   87.81%   85.47%   -2.35%     
==========================================
  Files         188      189       +1     
  Lines       50326    50404      +78     
  Branches    50326    50404      +78     
==========================================
- Hits        44195    43082    -1113     
- Misses       4047     5226    +1179     
- Partials     2084     2096      +12     
Flag Coverage Δ
client 60.89% <ø> (+0.36%) ⬆️
rest 55.65% <ø> (+0.02%) ⬆️
server 48.56% <ø> (-3.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@LucaCappelletti94
LucaCappelletti94 force-pushed the feat/r92-synced-references branch from 9cf8a8e to d91b397 Compare October 17, 2026 17:27
@LucaCappelletti94
LucaCappelletti94 force-pushed the feat/r92-synced-references branch from d91b397 to aa5e0f6 Compare October 17, 2026 20:56
@sonarqubecloud

Copy link
Copy Markdown

@LucaCappelletti94
LucaCappelletti94 added this pull request to stack #176 October 18, 2026 08:12
@LucaCappelletti94
LucaCappelletti94 force-pushed the feat/r92-synced-references branch from aa5e0f6 to 049a457 Compare October 18, 2026 08:12
Base automatically changed from r92/synced-references-client to main October 18, 2026 08:13
@LucaCappelletti94
LucaCappelletti94 force-pushed the feat/r92-synced-references branch from 049a457 to 6d57594 Compare October 18, 2026 08:13
@LucaCappelletti94
LucaCappelletti94 merged commit 46d2bef into main Oct 18, 2026
21 checks passed
@LucaCappelletti94
LucaCappelletti94 deleted the feat/r92-synced-references branch October 18, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant