fix: strip leading blank lines before license insertion#110
Draft
Wheest wants to merge 1 commit intoLucas-C:masterfrom
Draft
fix: strip leading blank lines before license insertion#110Wheest wants to merge 1 commit intoLucas-C:masterfrom
Wheest wants to merge 1 commit intoLucas-C:masterfrom
Conversation
Previously, when a file started with blank lines, the license would be inserted after them rather than at line 1. This caused issues when combined with formatters that sort statements to the top of files. The fix: - Leading blank lines (before any content) are now stripped - Blank lines after shebang/encoding directives are preserved - License is inserted at the correct position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #107
When a file starts with blank lines, the license is currently inserted after them rather than at line 1. This causes issues when combined with formatters like buildifier that sort statements to the top of files.
Changes
Test plan