perf(dflash): split-chain fast rollback with F32 SSM checkpoints (+29% decode)#506
Open
Amidwestnoob wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 13 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
|
@Amidwestnoob thanks for the contribution, please review and fix cubic reviews |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmark
Controlled dual-GPU A/B/A benchmark on two RTX 3090 24 GB cards using the same pinned models, prompt, generation length, power/thermal conditions, and layer split (
--target-gpus 0,1 --target-layer-split 12,11). Each block used one discarded warmup and five measured runs.All 15 measured runs produced byte-identical 256-token output:
1653a412811d3b87e26aab900e801b411fd68f9214b512ae984db6404b82204fA1/A2 baseline drift was 0.48%. Maximum observed GPU temperature was 64 C.
Memory trade-off
The F32 SSM checkpoint storage adds exactly 1,774,190,592 bytes (~1.65 GiB) of persistent GPU memory in the tested split configuration. Both GPUs are required for the tested 27B configuration; a single RTX 3090 is not sufficient.
Safety boundary
supports_tree_verify()remains unconditionally false in production.DFLASH_SPLIT_FAST_ROLLBACKand requires successful capture validation.Verification
mainat5e302cbb483819cd21e72f5dd8becaa609eca8cfsrc[7]Scope
Measured on the exact dual-RTX-3090 configuration above with a 1,024-token prompt and 256 generated tokens. No performance claim is made for single-GPU execution, sibling-tree verification, other models, or other hardware.