Skip to content

fix(ds4): propagate sampler config in layer split #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Graffioh wants to merge 1 commit into
base: codex/ds4-rocmfpx-server
Choose a base branch
from
+26 −1
Draft

fix(ds4): propagate sampler config in layer split #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion server/src/deepseek4/deepseek4_layer_split_adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,10 @@ bool DeepSeek4LayerSplitAdapter::init_mixed_target_split() {
}

void DeepSeek4LayerSplitAdapter::begin_request(const GenerateRequest & req) {
(void)req;
sampler_ = req.sampler;
if (req.do_sample && sampler_.seed != 0) {
sampler_rng_.seed(sampler_.seed);
}
}

void DeepSeek4LayerSplitAdapter::reset_request_state() {
Expand Down
22 changes: 22 additions & 0 deletions server/tests/test_deepseek4_unit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,27 @@ static void test_hc_state_dimensions() {
std::fprintf(stderr, g_failures ? " done\n" : " ok\n");
}

static void test_layer_split_request_propagates_sampler() {
std::fprintf(stderr, " test_layer_split_request_propagates_sampler ...");

DeepSeek4LayerSplitAdapter adapter({});
GenerateRequest req;
req.do_sample = true;
req.sampler.temp = 0.25f;
req.sampler.top_p = 0.9f;
req.sampler.seed = 42;

adapter.begin_request(req);

TEST_ASSERT(adapter.sampler_.temp == req.sampler.temp);
TEST_ASSERT(adapter.sampler_.top_p == req.sampler.top_p);
TEST_ASSERT(adapter.sampler_.seed == req.sampler.seed);
std::mt19937_64 expected(req.sampler.seed);
TEST_ASSERT(adapter.sampler_rng_() == expected());

std::fprintf(stderr, g_failures ? " done\n" : " ok\n");
}

static void test_loader_rejects_missing_required_metadata(ggml_backend_t backend) {
std::fprintf(stderr, " test_loader_rejects_missing_required_metadata ...");

Expand Down Expand Up @@ -1558,6 +1579,7 @@ int main() {
test_auto_split_computation();
test_layer_range_validation();
test_hc_state_dimensions();
test_layer_split_request_propagates_sampler();
test_loader_rejects_missing_required_metadata(backend);
test_loader_rejects_invalid_compress_ratio_type(backend);
test_loader_rejects_zero_vocab_size(backend);
Expand Down