refactor(server): standardize generation error codes#511
Merged
davide221 merged 1 commit intoJul 11, 2026
Conversation
c2e335a to
b040198
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GenerateErrorCodevalues across all generation backendsstd::optional<GenerateError>instead of separate boolean, enum, and string fieldsok(),succeed(), andfail()helpers to keep success and failure states consistentWhy
Equivalent failures previously used inconsistent free-form strings such as
prefill/prefill_failed,decode/decode_failed, andbad slot/invalid_snapshot_slot. The typed error model makes shared failures consistent and compiler-checked without losing architecture-specific diagnostics.Compatibility
The daemon response shape remains
err <code>, but recurrent legacy values are normalized to descriptive codes such asprefill_failed,decode_failed,context_overflow, andinvalid_snapshot_slot. Backend-specific failures now usebackend_specific; their detailed diagnostics remain available in server logs.Validation
GenerateResultstate-consistency coveragegit diff --check