fix(pinner.xyz): pin astro to 7.0.3 to fix prerender trailing slash regression#1094
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
![kody-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
…ions PR #1090 (chore(deps): update dependencies) introduced two build-breaking dependency bumps: 1. Astro 7.0.3 -> 7.0.6: 7.0.4 changed trailing slash handling for dynamic file endpoints (e.g. [slug].png.ts) with trailingSlash: 'always', causing prerender to fail with 'Missing parameter: slug' on /images/og/default.png/. 2. react-icons 5.6.0 -> 5.7.0: SiHeroku was removed, causing build to fail with '"SiHeroku" is not exported by react-icons/si' in portal-framework-auth SocialProviders. Pinning both until the issues are properly resolved.
pcfreak30
force-pushed
the
fix/astro-prerender-trailing-slash
branch
from
527e9d2 to
1b49618
Compare
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
PR #1090 (
chore(deps): update dependencies) bumped Astro from7.0.3to7.0.6. Astro 7.0.4 changed trailing slash handling for dynamic file endpoints (e.g.[slug].png.ts) whentrailingSlash: "always"is set. This causes the prerenderer to fail with:This breaks the
@lumeweb/pinner.xyzbuild, which cascades to fail the entire CI build. Develop itself is broken (run #28774341033).Fix
Pin Astro to
7.0.3inpnpm-workspace.yamlcatalog until the upstream regression is resolved.Verification
pnpm buildfor@lumeweb/pinner.xyzpasses:Related
This pull request pins the Astro dependency to version 7.0.3 (down from ^7.0.6) to resolve a prerender trailing slash regression. The version is pinned in the pnpm workspace catalog and the lockfile is updated accordingly, which also adjusts related transitive dependencies such as the Astro compiler bindings, markdown packages, and other linked libraries to match the pinned Astro version.