Repository navigation
Fix NES UI Palette Base Address and PPU Scroll Reset - #12
Conversation
Correct palette initialization in ui_init() by properly writing the 16-byte background palette starting at PPU address $3F00 with color 0 as $0F (black background), color 1 as $30 (white text), colors 2-3 ($16, $27), and filling remaining entries with $0F. Also clean up PPU scroll reset by removing PPU_ADDR writes after PPU_SCROLL reset in ui_init() to prevent register corruption. Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Corrected palette initialization in
targets/nes/src/ui_nes.cto latch PPU address $3F00 and fill all 16 background palette bytes. Removed trailingPPU_ADDR = 0x00writes followingPPU_SCROLL = 0x00to prevent PPU scroll register corruption.PR created automatically by Jules for task 10596832207637083502 started by @ClausValcaTD