Skip to content

fix(render): fix NES palette $3F00 initialization and Game Boy GBDK font rendering - #15

Merged
ClausValcaTD merged 1 commit into
mainfrom
fix-ppu-palette-and-gb-font-init-8251907147048057832
Oct 22, 2026
Merged

ClausValcaTD merged 1 commit into
mainfrom
fix-ppu-palette-and-gb-font-init-8251907147048057832

Conversation

@ClausValcaTD

Copy link
Copy Markdown
Collaborator

Fixes blank/corrupted UI screens on NES and Game Boy targets:

  1. NES (targets/nes/src/ui_nes.c & main.c): Latch and write Palette RAM at $3F00 with background palette colors ($0F, $30, $16, $27) and fill remaining entries. Clean PPU scroll reset and PPU_MASK=0x1E setup.
  2. Game Boy (targets/gameboy/src/ui_gb.c & main.c & Makefile): Initialize GBDK font system (font_init, font_color(3, 0), font_load(font_min), font_set), enable SHOW_BKG and DISPLAY_ON, set BGP_REG = 0xE4 and CGB Palette 0, and use -Wm-yC CGB build flag.
  3. Automated verification: Updated scripts/capture_screenshots.sh and regenerated verified screenshots/nes_screenshot.png and screenshots/gb_screenshot.png with image variance > 50.0.

PR created automatically by Jules for task 8251907147048057832 started by @ClausValcaTD

Fix NES Palette RAM ($3F00) initialization and scroll latching in
ui_nes.c, and initialize GBDK font system, display registers, and BGP_REG
palette contrast in ui_gb.c. Ensure ui_init is called early in main.c
for both targets, and update scripts/capture_screenshots.sh and non-blank
screenshot artifacts.

Co-authored-by: ClausValcaTD <193546948+ClausValcaTD@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ClausValcaTD
ClausValcaTD merged commit a628286 into main Oct 22, 2026
2 checks passed
@ClausValcaTD
ClausValcaTD deleted the fix-ppu-palette-and-gb-font-init-8251907147048057832 branch October 22, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant