release/v1.37.21 - #797
Merged
Merged
Conversation
The two halves of a resolved dose were split across routes: the single intake route reset the medication's snooze but never closed the pending dose-due Web Push reminder, while the bulk route closed the reminder but left the snooze standing. Each path was missing exactly what the other had. A dose drained from a device's offline queue lands on these routes, so a synced take could keep ringing as snoozed or leave a stale web badge behind. The bulk route now nulls snoozedUntil once per affected medication when a non-skipped entry actually lands, and the by-id route dispatches the same fire-and-forget web clear the other intake paths have carried since v1.18.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two intake-path parity fixes: the bulk route now quiets an active snooze when a non-skipped dose lands (the single routes always did), and the single-medication route now closes the pending dose-due web reminder and refreshes the badge (the other paths have since v1.18.4). Both matter for doses drained from a phone's offline queue.