v1.37.23 — postpone reads as an action, not a menu row - #800
Merged
Conversation
The preventive-care card kept postponing in the overflow kebab, three taps from the thing a person actually wants when a due date does not fit: open the menu, find the row, open the sheet. The medication card has never done that — taken and skipped sit side by side on the card, one tap each — and the checkup card should read the same way. Postpone is a second button in the action row now, outline against the filled primary, at its natural width beside it. The dense list branch gets the same action as an icon button, so neither view offers what the other withholds. The kebab keeps edit, measurements and delete. The sheet behind the button is unchanged in what it offers (quick offsets, a free date, the honest-skip zone), but the offsets are computed on the calendar now rather than by adding 86 400 000 ms per day. Across a DST shift the old arithmetic moved the wall clock over midnight and wrote the neighbouring date, so a chip labelled "+7 days" could fill in the sixth or the eighth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postponing a checkup lived in the card's overflow kebab: open the menu, find the row, open the sheet. The medication card has never asked for that. It puts "genommen" and "übersprungen" side by side on the card, one tap each, and the checkup card should read the same way.
Postpone is a second button in the action row now, outline against the filled primary and at its natural width beside it. The dense list branch gets the same action as an icon button, so neither view offers what the other withholds. The kebab keeps edit, measurements and delete.
The sheet behind the button offers what it always did (quick offsets, a free date, the honest-skip zone), but the offsets are computed on the calendar rather than by adding 86 400 000 ms per day. Across a daylight-saving change the old arithmetic moved the wall clock past midnight and wrote the neighbouring date, so an option labelled "+7 Tage" could fill in the sixth or the eighth.
postponeOffsetTargetsis exported and pinned by three cases, including both directions of a Berlin shift; reverting it to the millisecond sum turns the DST case red.Gate: typecheck, lint, format:check, 1885 test files / 21445 tests, and
next buildall green locally.