refactor(mqlaunch): move system_check into the diagnostics lib (Step 11a)#44
Merged
Merged
Conversation
…Step 11a) Follow-up to the diagnostics slice. system_check was an isolated diagnostics function still in the monolith; move it verbatim into mqlaunch/lib/diagnostics.sh next to its siblings, closing the diagnostics concern. The lib is already sourced, so this needs no new source line — just delete the definition from the launcher and append it to the lib. Verbatim move, no behavior change: system_check still uses the ambient UI helpers and is invoked only at runtime by menus/command-mode, all of which run after the lib is sourced. Launcher: 1654 → 1547 lines (~530 out since 11a began). Smoke CONCERNS row extended (29 functions across 3 libs); AUTHORITY_MAP and CHANGELOG updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the diagnostics slice (#43).
system_checkwas an isolated diagnostics function still in the monolith — move it verbatim intomqlaunch/lib/diagnostics.shnext to its siblings, closing the diagnostics concern.mqlaunch.sh, append it to the lib.system_checkstill uses the ambient UI helpers and is invoked only at runtime by menus/command-mode (mq-system-menu,mq-main-menu, command-mode), all of which run after the lib is sourced.Guard
Extended the diagnostics
CONCERNSrow intests/monolith-delayer-smoke.sh— now 29 functions across 3 concern libs, all asserted defined-in-lib / sourced-by-launcher / not-redefined-in-monolith.Verification
docs/AUTHORITY_MAP.mdandCHANGELOG.mdupdated.Part of the
v2.0.0runtime-authority track; 11a unblocks Step 12 (v1 removal).🤖 Generated with Claude Code