chore(mqlaunch): remove dead run_git_screen from the launcher#46
Merged
Conversation
run_git_screen was defined at the top of terminal/launchers/mqlaunch.sh but had no live caller in the launcher graph — the live implementation used by the desktop git screen lives in tools/scripts/mqlaunch_desktop.sh. Surfaced while de-layering the git concern (Step 11a); removed here as a standalone dead-code cleanup rather than laundered into a lib as if it were live. Launcher: 1479 → 1457 lines. Full selftest suite green — nothing referenced it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the dead
run_git_screenfromterminal/launchers/mqlaunch.sh.It was defined but had no live caller in the launcher's runtime graph. The live implementation (used by the desktop git screen) is a separate copy in
tools/scripts/mqlaunch_desktop.sh, which keeps its own.Surfaced while de-layering the git concern (Step 11a, #45). Handled as a standalone dead-code cleanup rather than folded into a refactor — moving dead code into a lib would misrepresent it as live.
Verification
grep -rn run_git_screen(excl. backups/v1/mqlaunch_desktop) shows only the definition + its own internal reference — no caller.CHANGELOG
Removedentry added.🤖 Generated with Claude Code