Skip to content

[rack] Parse query string with URI.decode_www_form #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MDA2AV merged 3 commits into from
Sep 3, 2026
Merged

[rack] Parse query string with URI.decode_www_form #1433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4125130
[rack] Parse query string with URI.decode_www_form
p8 Sep 3, 2026
ceee40e
Benchmark results: 2 frameworks (all tests) [skip ci]
github-actions[bot] Sep 3, 2026
bf0c872
[rack] Parse query string with URI.decode_www_form
p8 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frameworks/rack-falcon/app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Our Rack application to be executed by rackup

require 'rack'
require 'uri'

class App
CONTENT_TYPE = 'Content-Type'
Expand All @@ -14,15 +15,15 @@ def call(env)
when '/pipeline'
render_plain 'ok'
when '/baseline11'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
params = URI.decode_www_form(env['QUERY_STRING']).to_h
total = params['a'].to_i + params['b'].to_i
if env['REQUEST_METHOD'] == 'POST'
body = env["rack.input"]&.read
total += body.to_i
end
render_plain total.to_s
when '/baseline2'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
params = URI.decode_www_form(env['QUERY_STRING']).to_h
total = params['a'].to_i + params['b'].to_i
render_plain total.to_s
else
Expand Down
5 changes: 3 additions & 2 deletions frameworks/rack-iodine/app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# Our Rack application to be executed by rackup

require 'rack'
require 'uri'

class App
CONTENT_TYPE = 'Content-Type'
Expand All @@ -13,15 +14,15 @@ def call(env)
when '/pipeline'
render_plain 'ok'
when '/baseline11'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
params = URI.decode_www_form(env['QUERY_STRING']).to_h
total = params['a'].to_i + params['b'].to_i
if env['REQUEST_METHOD'] == 'POST'
body = env["rack.input"]&.read
total += body.to_i
end
render_plain total.to_s
when '/baseline2'
params = Rack::Utils.parse_query(env['QUERY_STRING'])
params = URI.decode_www_form(env['QUERY_STRING']).to_h
total = params['a'].to_i + params['b'].to_i
render_plain total.to_s
else
Expand Down
88 changes: 44 additions & 44 deletions site/data/results/rack-falcon.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,106 +4,106 @@
"baseline-4096": {
"framework": "rack-falcon",
"language": "Ruby",
"rps": 523648,
"avg_latency": "7.82ms",
"p99_latency": "12.80ms",
"cpu": "6518.4%",
"memory": "1.3GiB",
"rps": 541466,
"avg_latency": "7.55ms",
"p99_latency": "11.30ms",
"cpu": "6562.8%",
"memory": "1.1GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "44.43MB/s",
"input_bw": "40.45MB/s",
"bandwidth": "45.95MB/s",
"input_bw": "41.83MB/s",
"reconnects": 0,
"status_2xx": 2618243,
"status_2xx": 2707332,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
"latency-10k-1024": {
"framework": "rack-falcon",
"language": "Ruby",
"rps": 9978,
"avg_latency": "164.7us",
"p99_latency": "340.0us",
"cpu": "118.0%",
"memory": "1.1GiB",
"rps": 9982,
"avg_latency": "166.4us",
"p99_latency": "524.0us",
"cpu": "118.8%",
"memory": "765MiB",
"connections": 1024,
"threads": 64,
"duration": "20s",
"pipeline": 1,
"bandwidth": "0.88MB/s",
"reconnects": 0,
"status_2xx": 199595,
"status_2xx": 199668,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0,
"cpu_usec": 24082380,
"cpu_per_req_us": 120.6562,
"cpu_usec": 24459671,
"cpu_per_req_us": 122.5017,
"target_rate": 10000,
"rate_ratio": 0.9978,
"p99_9_latency": "8236.0us"
"rate_ratio": 0.9982,
"p99_9_latency": "12580.0us"
},
"latency-1m-1024": {
"framework": "rack-falcon",
"language": "Ruby",
"rps": 549126,
"avg_latency": "4075897.8us",
"p99_latency": "11399168.0us",
"cpu": "6473.6%",
"memory": "1.1GiB",
"rps": 569602,
"avg_latency": "3886927.2us",
"p99_latency": "10940416.0us",
"cpu": "6544.5%",
"memory": "831MiB",
"connections": 1024,
"threads": 64,
"duration": "20s",
"pipeline": 1,
"bandwidth": "48.32MB/s",
"bandwidth": "50.13MB/s",
"reconnects": 0,
"status_2xx": 10986943,
"status_2xx": 11396451,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0,
"cpu_usec": 1268077684,
"cpu_per_req_us": 115.4168,
"cpu_usec": 1275904694,
"cpu_per_req_us": 111.9563,
"target_rate": 1000000,
"rate_ratio": 0.5491,
"p99_9_latency": "13021184.0us"
"rate_ratio": 0.5696,
"p99_9_latency": "12251136.0us"
},
"limited-conn-4096": {
"framework": "rack-falcon",
"language": "Ruby",
"rps": 481962,
"avg_latency": "8.43ms",
"p99_latency": "73.20ms",
"cpu": "6574.3%",
"memory": "1.3GiB",
"rps": 503900,
"avg_latency": "8.04ms",
"p99_latency": "70.40ms",
"cpu": "6255.5%",
"memory": "894MiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "40.89MB/s",
"input_bw": "37.23MB/s",
"reconnects": 240789,
"status_2xx": 2409812,
"bandwidth": "42.75MB/s",
"input_bw": "38.93MB/s",
"reconnects": 251722,
"status_2xx": 2519502,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
"pipelined-4096": {
"framework": "rack-falcon",
"language": "Ruby",
"rps": 795966,
"avg_latency": "81.94ms",
"p99_latency": "112.60ms",
"cpu": "6657.5%",
"rps": 801850,
"avg_latency": "81.11ms",
"p99_latency": "113.20ms",
"cpu": "6666.4%",
"memory": "1.0GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 16,
"bandwidth": "67.54MB/s",
"bandwidth": "68.04MB/s",
"reconnects": 0,
"status_2xx": 3979831,
"status_2xx": 4009253,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
Expand Down
90 changes: 45 additions & 45 deletions site/data/results/rack-iodine.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,106 +4,106 @@
"baseline-4096": {
"framework": "rack-iodine",
"language": "Ruby",
"rps": 62640,
"avg_latency": "63.27ms",
"p99_latency": "229.60ms",
"cpu": "4860.4%",
"memory": "5.0GiB",
"rps": 62831,
"avg_latency": "62.59ms",
"p99_latency": "211.70ms",
"cpu": "4829.1%",
"memory": "4.9GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "7.35MB/s",
"input_bw": "4.84MB/s",
"bandwidth": "7.37MB/s",
"input_bw": "4.85MB/s",
"reconnects": 0,
"status_2xx": 313200,
"status_2xx": 314156,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
"latency-10k-1024": {
"framework": "rack-iodine",
"language": "Ruby",
"rps": 9966,
"avg_latency": "140.0us",
"p99_latency": "148.0us",
"cpu": "88.3%",
"memory": "4.8GiB",
"rps": 9951,
"avg_latency": "136.4us",
"p99_latency": "140.0us",
"cpu": "95.5%",
"memory": "4.3GiB",
"connections": 1024,
"threads": 64,
"duration": "20s",
"pipeline": 1,
"bandwidth": "1.22MB/s",
"bandwidth": "1.21MB/s",
"reconnects": 0,
"status_2xx": 199358,
"status_2xx": 199051,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0,
"cpu_usec": 14260870,
"cpu_per_req_us": 71.534,
"cpu_usec": 14382756,
"cpu_per_req_us": 72.2566,
"target_rate": 10000,
"rate_ratio": 0.9966,
"p99_9_latency": "26216.0us"
"rate_ratio": 0.9951,
"p99_9_latency": "25256.0us"
},
"latency-1m-1024": {
"framework": "rack-iodine",
"language": "Ruby",
"rps": 994864,
"avg_latency": "3719.6us",
"p99_latency": "105952.0us",
"cpu": "6434.6%",
"memory": "4.8GiB",
"rps": 995562,
"avg_latency": "377.7us",
"p99_latency": "837.0us",
"cpu": "6083.9%",
"memory": "4.4GiB",
"connections": 1024,
"threads": 64,
"duration": "20s",
"pipeline": 1,
"bandwidth": "121.37MB/s",
"bandwidth": "121.46MB/s",
"reconnects": 0,
"status_2xx": 19901977,
"status_2xx": 19915391,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0,
"cpu_usec": 1213259590,
"cpu_per_req_us": 60.9618,
"cpu_usec": 1116515635,
"cpu_per_req_us": 56.063,
"target_rate": 1000000,
"rate_ratio": 0.9949,
"p99_9_latency": "358016.0us"
"rate_ratio": 0.9956,
"p99_9_latency": "51472.0us"
},
"limited-conn-4096": {
"framework": "rack-iodine",
"language": "Ruby",
"rps": 59238,
"avg_latency": "66.77ms",
"p99_latency": "247.20ms",
"cpu": "4837.3%",
"memory": "5.2GiB",
"rps": 59158,
"avg_latency": "66.82ms",
"p99_latency": "231.20ms",
"cpu": "4812.8%",
"memory": "4.7GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 1,
"bandwidth": "6.95MB/s",
"input_bw": "4.58MB/s",
"reconnects": 27840,
"status_2xx": 296193,
"bandwidth": "6.94MB/s",
"input_bw": "4.57MB/s",
"reconnects": 27791,
"status_2xx": 295791,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
},
"pipelined-4096": {
"framework": "rack-iodine",
"language": "Ruby",
"rps": 2380906,
"avg_latency": "26.70ms",
"p99_latency": "68.80ms",
"cpu": "6480.7%",
"rps": 2329452,
"avg_latency": "27.11ms",
"p99_latency": "62.40ms",
"cpu": "6778.4%",
"memory": "4.6GiB",
"connections": 4096,
"threads": 64,
"duration": "5s",
"pipeline": 16,
"bandwidth": "279.18MB/s",
"bandwidth": "273.17MB/s",
"reconnects": 0,
"status_2xx": 11904531,
"status_2xx": 11647260,
"status_3xx": 0,
"status_4xx": 0,
"status_5xx": 0
Expand Down
18 changes: 9 additions & 9 deletions site/static/logs/baseline/4096/rack-falcon.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Falcon::Command::Host","object_id":896,"message":"Falcon Host v0.54.2 taking flight!\n- Configuration: falcon.rb\n- To terminate: Ctrl-C or kill 1\n- To reload: kill -HUP 1\n"}
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Container::Notify::Console","object_id":904,"message":{"status":"Initializing controller..."}}
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Falcon::Service::Server","object_id":920,"message":"Starting app on #<Async::HTTP::Endpoint http://0.0.0.0:8080/ {protocol: Async::HTTP::Protocol::HTTP11}>"}
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Controller starting..."}
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Starting container..."}
{"time":"2026-09-03T12:05:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Falcon::Command::Host","object_id":896,"message":"Falcon Host v0.54.2 taking flight!\n- Configuration: falcon.rb\n- To terminate: Ctrl-C or kill 1\n- To reload: kill -HUP 1\n"}
{"time":"2026-09-03T12:05:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Container::Notify::Console","object_id":904,"message":{"status":"Initializing controller..."}}
{"time":"2026-09-03T12:05:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Falcon::Service::Server","object_id":920,"message":"Starting app on #<Async::HTTP::Endpoint http://0.0.0.0:8080/ {protocol: Async::HTTP::Protocol::HTTP11}>"}
{"time":"2026-09-03T12:05:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Controller starting..."}
{"time":"2026-09-03T12:05:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Starting container..."}
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
Expand Down Expand Up @@ -67,8 +67,8 @@
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Waiting for startup..."}
{"time":"2026-09-03T12:05:51+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Waiting for startup..."}
/app/vendor/bundle/ruby/4.0.0/gems/async-container-0.30.0/lib/async/container/notify/pipe.rb:68: warning: IO::Buffer is experimental and both the Ruby and C interface may change in the future!
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Finished startup."}
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Container::Notify::Console","object_id":904,"message":{"ready":true,"size":65}}
{"time":"2026-09-02T11:15:50+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Controller started..."}
{"time":"2026-09-03T12:05:51+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Finished startup."}
{"time":"2026-09-03T12:05:51+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Container::Notify::Console","object_id":904,"message":{"ready":true,"size":65}}
{"time":"2026-09-03T12:05:51+00:00","severity":"info","process_id":1,"fiber_id":888,"pid":1,"subject":"Async::Service::Controller","object_id":928,"message":"Controller started..."}
Loading
Loading