fix: preserve RMSD reference after reconnect - #71
Open
vvsrinath wants to merge 2 commits into
Open
Conversation
fix: preserve RMSD reference on reconnect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves the RMSD reference when the dashboard reconnects.
Previously, _update_selection() always replaced reference_positions with the current positions of the newly connected Universe. This caused the RMSD reference to change after reconnecting.
The implementation adds reset_reference to _update_selection(). Reconnection uses reset_reference=False, preserving the existing reference, while changing the RMSD selection continues to reset the reference.
Added a regression test covering the reconnect scenario.
Focused test result: 5 passed, 68 deselected.
The remaining test-suite issue appears to be related to an environment dependency and is being investigated separately.