Skip to content

bug: m_bubbles_EL: delete non-finite bubbles in the boundary enforcement #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aliencaocao wants to merge 4 commits into
base: master
Choose a base branch
from
+3 −9
Open

bug: m_bubbles_EL: delete non-finite bubbles in the boundary enforcement #1772

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7727273
m_bubbles_EL: delete non-finite bubbles in the boundary enforcement
aliencaocao Aug 27, 2026
f909adf
Merge branch 'master' into fix/lagrange-nan-bubble
aliencaocao Aug 27, 2026
2a898f0
Merge branch 'master' into fix/lagrange-nan-bubble
sbryngelson Aug 28, 2026
74727ba
Merge branch 'master' into fix/lagrange-nan-bubble
sbryngelson Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/simulation/m_bubbles_EL.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,9 +1361,7 @@ contains
& 2) <= pcomm_coords(1)%end) then
wrap_bubble_dir(k, 1) = 1
wrap_bubble_loc(k, 1) = 1
else if (mtn_pos(k, 1, 2) >= x_cb(m)) then
keep_bubble(k) = 0
else if (mtn_pos(k, 1, 2) < x_cb(-1)) then
else if (.not. (mtn_pos(k, 1, 2) >= x_cb(-1) .and. mtn_pos(k, 1, 2) < x_cb(m))) then
Comment thread
aliencaocao marked this conversation as resolved.
Comment thread
aliencaocao marked this conversation as resolved.
keep_bubble(k) = 0
end if

Expand All @@ -1381,9 +1379,7 @@ contains
& 2) <= pcomm_coords(2)%end) then
wrap_bubble_dir(k, 2) = 1
wrap_bubble_loc(k, 2) = 1
else if (mtn_pos(k, 2, 2) >= y_cb(n)) then
keep_bubble(k) = 0
else if (mtn_pos(k, 2, 2) < y_cb(-1)) then
else if (.not. (mtn_pos(k, 2, 2) >= y_cb(-1) .and. mtn_pos(k, 2, 2) < y_cb(n))) then
keep_bubble(k) = 0
end if

Expand All @@ -1402,9 +1398,7 @@ contains
& 2) <= pcomm_coords(3)%end) then
wrap_bubble_dir(k, 3) = 1
wrap_bubble_loc(k, 3) = 1
else if (mtn_pos(k, 3, 2) >= z_cb(p)) then
keep_bubble(k) = 0
else if (mtn_pos(k, 3, 2) < z_cb(-1)) then
else if (.not. (mtn_pos(k, 3, 2) >= z_cb(-1) .and. mtn_pos(k, 3, 2) < z_cb(p))) then
keep_bubble(k) = 0
end if
end if
Expand Down
Loading