Skip to content

Exit the pTg Newton iteration when its line search cannot reduce the residual #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aliencaocao wants to merge 1 commit into from
+6 −1
Closed

Exit the pTg Newton iteration when its line search cannot reduce the residual #2096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/common/m_phase_change.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ contains
real(wp) :: mCP, mCPD, mCVGP, mCVGP2, mQ
real(wp) :: ml, ml_try, mT, pS_try, pmin, lambda, resnorm, resnorm_try
real(wp) :: dFdT, dTdm, dTdp, detJ
logical :: line_search_gained
integer :: ns, ls

! total reacting mass is conserved; the liquid mass ml is the primary unknown, vapor mass = mT - ml
Expand Down Expand Up @@ -411,17 +412,21 @@ contains
! backtracking line search: halve the step until the residual decreases, keeping the state
! physical (0 <= ml <= mT, pS above the stiffened-gas floor)
lambda = 1.0_wp
line_search_gained = .false.
do ls = 1, ptg_ls_max
ml_try = min(max(ml + lambda*DeltamP(1), 0.0_wp), mT)
pS_try = max(pS + lambda*DeltamP(2), pmin)
call s_compute_ptg_residual(ml_try, mT, pS_try, j, k, l, q_cons_vf, rhoe, R2D_try, TS, mCP, mQ, mCVGP, mCVGP2, mCPD)
resnorm_try = sqrt(R2D_try(1)**2 + R2D_try(2)**2)
if ((resnorm_try < resnorm) .or. (ls == ptg_ls_max)) exit
line_search_gained = resnorm_try < resnorm
if (line_search_gained .or. (ls == ptg_ls_max)) exit
lambda = 0.5_wp*lambda
end do

! accept the trial state (TS, mCP, mQ, mCVGP, mCVGP2, mCPD already set to it by the last call)
ml = ml_try; pS = pS_try; R2D = R2D_try; resnorm = resnorm_try

! A step that cannot lower the residual ends the iteration at the accepted state
end do

! commit the reacting masses (mT conserved) and set the common temperature
Expand Down
Loading