Retry all 500 error codes and raise errors during CLI bulk-update and… - #394
Merged
jonavellecuerdo merged 1 commit intoJul 29, 2026
Conversation
ghukill
requested changes
Jul 28, 2026
ghukill
left a comment
ghukill
left a comment
Contributor
There was a problem hiding this comment.
Other than a proposal to remove "Retryable", I think it looks great for a quick first pass at getting successful AOSS indexing.
jonavellecuerdo
added a commit
that referenced
this pull request
Jul 29, 2026
ghukill
approved these changes
Jul 29, 2026
… reindex-source Why these changes are being introduced: * Allow TIM to retry when any 500 error codes are raised based on initial results from reindexing sources to AOSS in Prod. The CLI bulk-update and reindex-source commands should skip proceeding with the remaining steps if tim_os.bulk_index fails. This prevents the logging of incorrect summary results due to errors. How this addresses that need: * Call ctx.exit when bulk indexing fails during CLI bulk-update and reindex-source * Update conditions to check for error codes >= 500 and <600 * Fix log message for tim.helpers.retry Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/TIMX-626
jonavellecuerdo
force-pushed
the
TIMX-626-retry-5XX-error-codes-and-raise-errors-cli-bulk-update
branch
from
July 29, 2026 13:40
da16cae to
7320a95
Compare
jonavellecuerdo
deleted the
TIMX-626-retry-5XX-error-codes-and-raise-errors-cli-bulk-update
branch
July 29, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Allow TIM to retry when any 500 error codes are raised based on initial results from reindexing sources to AOSS in Prod. The CLI bulk-update and reindex-source commands should skip proceeding with the remaining steps if tim_os.bulk_index fails. This prevents the logging of incorrect summary results due to errors.
How can a reviewer manually see the effects of these changes?
Please review the following CloudWatch logstreams in Dev:
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review