USE-688: Load more button style, copy, and focus updates - #464
Conversation
Coverage Report for CI Build 33765649471Coverage remained the same at 98.304%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small and scoped to UI/UX polish, with only minor maintainability feedback noted around CSS selector choice.
Pull request overview
This PR refines the new “Load more” pagination UX in TIMDEX UI by updating the control’s copy/styling and improving post-append keyboard focus behavior after Turbo Stream results are appended.
Changes:
- Updates load-more link text to “Show more results”.
- Adjusts pagination/load-more styling to left-align the load-more control and use secondary button styling.
- Moves focus (after appending results via Turbo Stream) to the title link of the first newly appended result.
File summaries
| File | Description |
|---|---|
| app/views/search/_load_more.html.erb | Updates the load-more link copy shown to users. |
| app/javascript/loading_spinner.js | Hooks into Turbo stream rendering to focus the first newly appended result title after “load more”. |
| app/assets/stylesheets/partials/_pagination.scss | Updates layout/styling for pagination and load-more containers to match desired button alignment and presentation. |
Review details
Suppressed comments (1)
app/assets/stylesheets/partials/_pagination.scss:60
- Follow-up to the selector change above: this rule should also target the
.load-moreclass (not the#load-moreid) to keep styling consistent and keep the id reserved for Turbo Stream replacement.
#load-more {
justify-content: start;
}
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -1,8 +1,7 @@ | |||
| .pagination-container { | |||
| .pagination-container, #load-more { | |||
JPrevost
left a comment
There was a problem hiding this comment.
Focus looks correct to me in both pagination and load more mode.
I have no strong feeling on the copilot review feedback so make that change or not based your preference.
Developer
Now that Load More pagination is implemented, we wanted to make a few UX/UI changes:
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing