Skip to content

USE-688: Load more button style, copy, and focus updates - #464

Merged
djanelle-mit merged 2 commits into
mainfrom
use-688
Sep 3, 2026
Merged

USE-688: Load more button style, copy, and focus updates#464
djanelle-mit merged 2 commits into
mainfrom
use-688

Conversation

@djanelle-mit

@djanelle-mit djanelle-mit commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Developer

Now that Load More pagination is implemented, we wanted to make a few UX/UI changes:

  • Button is styled to match other secondary buttons and left aligned
  • Copy is changed to "Show more results" to imply staying in place and seeing more
  • Focus after showing the next set of results is moved to the title of the first new result.
Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33765649471

Coverage remained the same at 98.304%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1710
Covered Lines: 1681
Line Coverage: 98.3%
Coverage Strength: 82.21 hits per line

💛 - Coveralls

@mitlib
mitlib temporarily deployed to timdex-ui-pi-use-688-dte52lf8m September 3, 2026 14:16 Inactive
@JPrevost
JPrevost requested a lite review from Copilot September 3, 2026 17:11
@JPrevost JPrevost self-assigned this Sep 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are small and scoped to UI/UX polish, with only minor maintainability feedback noted around CSS selector choice.

Pull request overview

This PR refines the new “Load more” pagination UX in TIMDEX UI by updating the control’s copy/styling and improving post-append keyboard focus behavior after Turbo Stream results are appended.

Changes:

  • Updates load-more link text to “Show more results”.
  • Adjusts pagination/load-more styling to left-align the load-more control and use secondary button styling.
  • Moves focus (after appending results via Turbo Stream) to the title link of the first newly appended result.
File summaries
File Description
app/views/search/_load_more.html.erb Updates the load-more link copy shown to users.
app/javascript/loading_spinner.js Hooks into Turbo stream rendering to focus the first newly appended result title after “load more”.
app/assets/stylesheets/partials/_pagination.scss Updates layout/styling for pagination and load-more containers to match desired button alignment and presentation.
Review details

Suppressed comments (1)

app/assets/stylesheets/partials/_pagination.scss:60

  • Follow-up to the selector change above: this rule should also target the .load-more class (not the #load-more id) to keep styling consistent and keep the id reserved for Turbo Stream replacement.
#load-more {
  justify-content: start;
}
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@@ -1,8 +1,7 @@
.pagination-container {
.pagination-container, #load-more {

@JPrevost JPrevost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focus looks correct to me in both pagination and load more mode.

I have no strong feeling on the copilot review feedback so make that change or not based your preference.

@djanelle-mit
djanelle-mit merged commit b90d097 into main Sep 3, 2026
8 checks passed
@djanelle-mit
djanelle-mit deleted the use-688 branch September 3, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants