Rebasing bns model commits from bns-o3-mdc branch onto dev branch - #544
Merged
Merged
Conversation
* amplfi bns hlv config * update ml4gw and amplfi versions (cherry picked from commit eb0ccc6)
* amplfi bns hlv config (ML4GW#421) * amplfi bns hlv config * update ml4gw and amplfi versions (cherry picked from commit eb0ccc6) * change config params and add correct preprocessor (cherry picked from commit 3ecc506) * change parameters in online project's config and update preprocessor (cherry picked from commit 42484f5) * Fix issues with whitened being a tuple (cherry picked from commit 8c609c1) * Align decimator API between amplfi and aframe (cherry picked from commit 5871638) * Update configs (cherry picked from commit fc0ab62) * set ml4gw>=0.8.0, update lock file --------- Co-authored-by: Bhavya Gupta <bhavya.gupta@dgx1.ligo-wa.caltech.edu> Co-authored-by: William Benoit <benoi090@umn.edu>
Contributor
|
@bhgupta20 This looks good to me. Just delete |
Contributor
Author
|
Removed the |
bhgupta20
changed the title
bns-o3-mdc branch into dev branchbns-o3-mdc branch onto dev branch
wbenoit26
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wbenoit26 @deepchatterjeeligo This is the first attempt at rebasing the bns model commits from the O3 MDC branch onto
dev.augmentoras an optional input to the online project's config, preserving backwards compatibility. This also future-proofs the pipeline; if we plan to use any other augmentor down the line.amplfi-bnsprototype is not compatible with this PR as it requiresml4gw==0.7.8due to thedecimatormodule inamplfi. Any plans to useamplfi-bnswould require manual changes. This should be fine for now sinceamplfi-bnsis still in the RnD phase.