Repository navigation
test(runtime): wait for delivered background completion inputs - #71
Merged
Merged
Conversation
The background-completion rows' quiet-only wait can snapshot inside the publish-delivery window and miss the successor input; the wait now includes the awaited condition itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
composedAwaitCompletionInputhelper waits until the session is quiet and the runtime-origin completion input is present in the same snapshot, then returns its text. Both affected rows use it and keep their exact-text and presence-flag assertions.Tests
Full Go suite passed and the wails build with the webkit2_41 tag passed. The two affected tests also pass targeted. The flake itself is load-gated, so no deterministic failing-before run exists for it.