Skip to content

Add Simplified Chinese (zh_cn) localization#1

Merged
FirstMegaGame4 merged 1 commit into
MModding:mainfrom
Kite95:main
May 8, 2026
Merged

Add Simplified Chinese (zh_cn) localization#1
FirstMegaGame4 merged 1 commit into
MModding:mainfrom
Kite95:main

Conversation

@Kite95
Copy link
Copy Markdown
Contributor

@Kite95 Kite95 commented May 8, 2026

hiya! I really love the Japanese aesthetic of your mod! I noticed the mod didn't have a Chinese translation yet, so I’ve provided a complete Simplified Chinese (zh_cn.json) translation

hiya! I really love the Japanese aesthetic of your mod!
I noticed the mod didn't have a Chinese translation yet, so I’ve provided a complete Simplified Chinese (zh_cn.json) translation
@FirstMegaGame4 FirstMegaGame4 self-requested a review May 8, 2026 17:29
@FirstMegaGame4 FirstMegaGame4 added the enhancement New feature or request label May 8, 2026
@FirstMegaGame4
Copy link
Copy Markdown
Member

Hi! We thank you a lot for this contribution, we're glad to see that you like it! Just running the workflow to check that everything is okay (it should be), and I'll merge the PR afterwards!

@FirstMegaGame4 FirstMegaGame4 merged commit 9d63653 into MModding:main May 8, 2026
1 check passed
@FirstMegaGame4
Copy link
Copy Markdown
Member

image Seems to work pretty well! I'll publish a new release for that.

PS: Just so you know, you've put your translation inside of the src/main/generated directory at first, but that's the directory for generated resources. Resources that are "static" (plain json files), are found inside of src/main/resources.

The reason that en_us.json is inside of the generated directory, is that it's part of the data generation output.
I'm just saying this so that you know it for the next time! Cause if I didn't pay attention the data generation could have probably just wiped out your translation... 😅

@FirstMegaGame4
Copy link
Copy Markdown
Member

@Kite95
Copy link
Copy Markdown
Contributor Author

Kite95 commented May 8, 2026

ohmy. right, thanks for pointing out the folder thing. I'll just put it in src/main/resources next time to save you the trouble.
anyway, thx for the warm welcome! Stoked to see it in the next release :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants