[pull] main from llvm:main - #1730
Merged
Merged
Conversation
…a estimates (#214191) Replaces the olds costs which were just instruction counts Still working on the bool reduction costs - these will be handled in a followup
If allocation of the Use[] in allocHungoffUses fails (e.g. due to OOM), it may happen that the destructor of User is called with NumUserOperands > 0. Then `Use::zap` tries to destruct Uses that were not constructed in the first place. Example scenario for SwitchInst: `SwitchInst::init()` is called, which means the constructor of the parent class User went through successfully, which means the destructor of User will be called eventually. If now `SwitchInst::init()` calls first `setNumHungOffUseOperands(2)` and then `allocHungoffUses()` and the allocation there fails, `~User()` is called and tries to destruct 2 Uses, which can lead to problems. This patch consequently ensures that first the allocation happens and then NumUserOperands is set accordingly, so that this problem is prevented.
Both the Itanium and the MS ABI want some cache for dynamic types. This moves the functionality from the Itanium ABI to the base class.
Similar to #207217 The RST-to-Markdown migration (#206181) converted the RST flag `:numbered:` into `:numbered: true`. MyST parses the toctree `numbered` option as `int_or_nothing`, so the string `true` fails with: ``` 'toctree': Invalid option value for 'numbered': true: invalid literal for int() with base 10: 'true' ``` This breaks the `-W` (warnings-as-errors) `docs-clang-html` build. Make `numbered` a valueless flag, which MyST accepts (equivalent to the original RST behavior of numbering all levels).
This allows `CPPLanguageRuntime` to contain more than one ABI runtime. For dynamic types, we ask each runtime if it knows how to deal with a vtable symbol. For exception breakpoints, we will create all breakpoints. Note that the MS ABI will only be added on Windows targets. So the MS ABI will not be added to `m_abi_runtimes` on other targets.
I'm not sure why Git decided to add two duplicate declarations when merging #212015, but this removes the duplicate ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )