Initialize tend_u_phys as zero#1022
Open
theweathermanda wants to merge 1 commit intoMPAS-Dev:atmosphere/develop-openaccfrom
Open
Initialize tend_u_phys as zero#1022theweathermanda wants to merge 1 commit intoMPAS-Dev:atmosphere/develop-openaccfrom
theweathermanda wants to merge 1 commit intoMPAS-Dev:atmosphere/develop-openaccfrom
Conversation
I've added code to initialize and reset tend_u_phys as 0._RKIND during each time step. Otherwise, these tendency values accumulate over successive time steps, which impacts the PV budget calculation in pv_diagnostics.F
theweathermanda
changed the base branch from
atmosphere/develop-openacc
to
hotfix-v7.4
theweathermanda
changed the base branch from
hotfix-v7.4
to
atmosphere/develop-openacc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added code to initialize and reset tend_u_phys as 0._RKIND during each time step. Otherwise, these tendency values accumulate over successive time steps, which impacts the PV budget calculation in pv_diagnostics.F