BC8 have wrong monster attributes#776
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request corrects an inversion in monster difficulty settings between Blood Castle 7 and Blood Castle 8. By swapping the attribute definitions for the respective monster sets, the PR ensures that the game's difficulty curve is properly maintained, with BC8 representing the highest challenge as intended. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adjusts monster attributes, including health, damage, defense, and resistances, for Blood Castle levels 7 and 8. The review feedback identifies several inconsistencies in the difficulty progression, specifically where monsters in Blood Castle 7 were assigned higher defense and resistance values than those in the harder Blood Castle 8. Additionally, a discrepancy was noted between the PR description and the monster IDs implemented in the code for Blood Castle 7.
sven-n
left a comment
There was a problem hiding this comment.
Thank you, can you add a configuration update plugin, too?
|
Code added. |
|
Thank you :) |
Fix: Swap attribute values between BC7 and BC8 monsters
Problem: BloodCastle7.cs originally created monsters 138-143 with high stats
(lvl 114-140, HP up to 215k), while BloodCastle8.cs created monsters 428-433 with
low stats (lvl 105-125, HP up to 60k). This was inverted — BC8 should be the hardest.
Solution: Swapped attribute values between the files.
Each monster keeps its number and name, only the stats change.
BloodCastle7.cs (map 17, BC7 — medium):
138 Chief Skeleton Warrior 7 ← 428 old stats (lvl 105, HP 29k, res 7f)
139 Chief Skeleton Archer 7 ← 429 old stats (lvl 106, HP 32k, res 7f)
140 Dark Skull Soldier 7 ← 430 old stats (lvl 110, HP 37k, res 7f)
141 Giant Ogre 7 ← 431 old stats (lvl 112, HP 45k, res 7f)
142 Red Skeleton Knight 7 ← 432 old stats (lvl 119, HP 55k, res 7f)
143 Magic Skeleton 7 ← 433 old stats (lvl 125, HP 60k, res 10f)
BloodCastle8.cs (map 52, BC8 — hardest):
428 Chief Skeleton Warrior 8 ← 138 old stats (lvl 114, HP 173.5k, res 8f)
429 Chief Skeleton Archer 8 ← 139 old stats (lvl 117, HP 175k, res 8f)
430 Dark Skull Soldier 8 ← 140 old stats (lvl 125, HP 184k, res 8f)
431 Giant Ogre 8 ← 141 old stats (lvl 129, HP 208k, res 8f)
432 Red Skeleton Knight 8 ← 142 old stats (lvl 132, HP 208.7k, res 8f)
433 Magic Skeleton 8 ← 143 old stats (lvl 140, HP 215k, res 11f)
Progression: BC6 (easiest) → BC7 (medium) → BC8 (hardest) ✓