fix: prevent sparse gaps after cross-process log rotation - #23
Open
Windsland52 wants to merge 1 commit into
Open
fix: prevent sparse gaps after cross-process log rotation#23Windsland52 wants to merge 1 commit into
Windsland52 wants to merge 1 commit into
Conversation
Member
Author
|
cc @MistEO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cause
After rotation, Logger previously reopened maafw.log with a long-lived truncating stream. If another process later rotated or truncated the same file, that stream retained its old file offset. Its next write could therefore create a large zero-filled gap, which then caused repeated oversized backups.
Validation
Sourcery 总结
通过将截断操作与长生命周期的日志写入分离,防止跨进程轮换后出现稀疏的日志空洞。
Bug 修复:
改进:
Original summary in English
Summary by Sourcery
Prevent sparse log gaps after cross-process rotation by separating truncation from long-lived log writing.
Bug Fixes:
Enhancements: