Repository navigation
feat: verify Captain’s Bridge install/update and accept gh CVE-2026-78669 records - #81
Conversation
…8669 records Document Codex update/activation, host/storage compatibility and failure states; add the exact-match gh vendor-client exceptions (stdlib, x/net) and a retained-report test. Refs #61.
timeleft--
left a comment
There was a problem hiding this comment.
The package/install proof and all 17 comparator tests pass, including the retained real arm64 reports and expiry failure. The exact exception mechanism is accepted: 250 inherited findings remain nonblocking, the two CVE-2026-78669 records use narrowly matched vendor-client exceptions, and no additional security gate or runtime restriction is requested. Reuse all unchanged native/browser acceptance; the Captain explicitly accepted existing missing-skill tests in issue #60 comment 6100483084.
Please make one grouped repair:
- Merge actual main 47152ec (PR #76, version 0.11.0), preserve both clients, and run the repository-local version updater before review. The next main merge is reserved for this PR; keep the changelog entry distinct from the preceding releases.
- In docs/first-officer-plugins.md, replace the unverified refresh placeholder with the supported
codex plugin marketplace upgrade hermes-helmetprocedure and verify installed version withcodex plugin list --marketplace hermes-helmet --json. Local Codex CLI 0.155.1 proves marketplace list reports marketplace roots, not installed versions. Remove the universal promise that one new chat activates MCP and the panel: distinguish installed files from the running connection and use a single consolidated activation where required by the host. Do not add a reload loop or a new native acceptance gate. - In the CVE-2026-78669 exception rationale, describe expected trusted outbound GitHub use without implying the wrapper enforces a host restriction. It forwards arbitrary arguments/hosts/absolute URLs and has no hard timeout; that residual exposure is already accepted in the handoff. Clarify that a fixed gh binary has not yet been pinned, rather than saying the upstream Go/x-net fix does not exist. Keep the exact identities, expiry, removal-on-fixed-gh rule and existing secret/provenance checks unchanged.
These are current-base/version reconciliation and two verified documentation corrections. No new product feature, security hardening project, image-base remediation or physical missing-skill test is requested. Run the affected checks and the existing required validation; retained scan fixtures stay outside source/package contents.
…met-61 # Conflicts: # CHANGELOG.md
…n rationale Address the PR #81 review: pin the supported codex plugin marketplace upgrade / plugin list --json procedure, separate installed files from the running connection instead of promising one chat activates MCP and the panel, describe the accepted outbound exposure in the CVE-2026-78669 rationale without implying a host restriction, and bump to 0.12.0 over main's 0.11.0. Refs #61.
timeleft--
left a comment
There was a problem hiding this comment.
Clean independent review of this exact worker head against actual main 47152ec. The grouped current-base/version and documentation corrections from review 5480320644 are resolved. Supported Codex upgrade and installed-version commands match CLI 0.155.1; the guide distinguishes installed files from running connection/panel adoption. The gh rationale now records expected trusted GitHub use and accepted arbitrary-host/URL/no-timeout residual exposure, with exact matching, expiry, provenance and secret checks preserved.
Independently reran all 17 comparator tests with retained real arm64 inputs, including post-expiry failure: pass. Current-base version check (0.11.0 to 0.12.0), ancestor check, whitespace and clean checkout pass. All six required source checks pass for this head. The PR changes only eight expected files relative to actual main; unchanged native/browser receipts remain valid, and the Captain's accepted missing-skill fixture decision remains recorded in #60. No material finding remains. Final merged-source artifacts and installation are separate closeout evidence; no publication or fresh desktop activation is claimed by this review.
Captain’s Bridge now documents installation, supported Codex updates, host/storage compatibility, and useful failure states for adopters using the existing plugin distribution. The guide distinguishes installed files from the running connection and panel. Native and browser acceptance from the earlier slices remains valid where their source is unchanged; the Captain accepted the existing missing-skill tests in #60.
The runtime-image comparator also accepts the two exact CVE-2026-78669 records in the pinned gh binary through its existing dated vendor-client exception mechanism. Inherited Nous image findings remain nonblocking. Secret, provenance, identity, and expiry checks remain intact; the rationale records the accepted residual exposure.
Validation: all 17 comparator tests pass, including retained real arm64 reports and post-expiry failure. Independent version validation passes against actual main 47152ec, advancing 0.11.0 to 0.12.0. Package/install and separate-process MCP checks use the maintained tooling. Scan inputs remain outside source and package contents.
Refs #61, part of #53. Claude installation documentation remains owned by #72. This PR does not publish a release or close the parent epic. Codex background updates remain unavailable on the measured host; native rendering, installed files, and runtime activation are separate evidence claims.