Vendors: pin MafiaNet v0.17.0 for in-session MTU black-hole recovery - #269
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe CMake MafiaNet dependency pin changes from v0.16.0 to v0.17.0. The release comment changes to describe in-session MTU black-hole detection. RAKNET protocol version 7 compatibility remains. ChangesMafiaNet dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates MafiaNet to provide in-session MTU black-hole recovery without changing the wire protocol or message format. The change is localized and no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bumps the MafiaNet pin from v0.16.0 (
667fa4e9) to v0.17.0 (9b0e240c).v0.16.0's 1400-byte MTU cap fixed tunnelled players on paths the handshake can probe; v0.17.0 adds the deferred follow-up for the ones it can't: a tunnel that black-holes large datagrams on the return path only (OpenVPN's defaults do exactly this — no UDP fragmentation, direction-asymmetric drops, OpenVPN/openvpn#823), or a path that shrinks mid-session. The reliability layer now detects the black-hole signature, steps the connection's MTU down the handshake's own ladder, and re-splits every queued message that no longer fits — instead of resending the same too-large datagram until the connection times out. Ordinary packet loss can never trigger a step-down.
Wire-compatible:
RAKNET_PROTOCOL_VERSIONstays at 7, no message ids move, and the split/reassembly wire format is unchanged (the new bookkeeping is sender-side only), so mixed 0.15/0.16/0.17 peers interoperate and a server-side bump helps players who have not updated. Release notes: https://github.com/MafiaHub/MafiaNet/releases/tag/v0.17.0Verified locally: a reconfigure fetches the pinned commit and
MafiaNetStatic,Framework, andFrameworkServerall build clean against it.Summary by CodeRabbit