Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the shared PostgreSQL Swarm stack to support the Fashion crawler in production by attaching the production-only Fashion overlay network alias and ensuring the Fashion database/role are provisioned during production deploys, with docs and static validation updated to match.
Changes:
- Add a production-only
makepad-postgres-fashionservice alias backed by a new external overlay network variable (MAKEPAD_POSTGRES_FASHION_DB_NETWORK). - Provision the Fashion database/role during production deploys and introduce an idempotent bootstrap SQL script (
bootstrap/fashion-app.sql). - Update README documentation and the static validation script to enforce the new wiring and bootstrap expectations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/validate-postgres-config.sh | Adds Fashion wiring/bootstrap invariants to the repo’s static configuration validation. |
| README.md | Documents the Fashion production network variable mapping, bootstrap invocation, and connection URI. |
| envs/production/compose.yml | Attaches Postgres to the production-only Fashion overlay network and exposes the makepad-postgres-fashion alias. |
| bootstrap/fashion-app.sql | New idempotent bootstrap to create/repair the fashion DB and fashion_crawler role using a password variable and advisory lock. |
| .github/workflows/manual-deploy.yml | Wires Fashion secrets/env vars, creates the Fashion overlay network in production, and provisions the Fashion DB/role with readiness checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kaanyagci
changed the base branch from
main
to
codex/fashion-iceberg-bootstrap
October 13, 2026 21:12
kaanyagci
marked this pull request as ready for review
October 13, 2026 21:12
kaanyagci
added this pull request to stack #60
October 13, 2026 21:12
kaanyagci
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Native GitHub stack
Native stack #60; builds on #58 and #59, followed by #8.
Validation
Real disposable bootstrap tests cover fresh/repeated installation, retained credentials, rejected ownership/privilege drift and catalog reader positive/negative access. Credential-reset regressions failed before the fix and passed afterward. GitHub bootstrap and general CI passed on the reviewed SHA.
Release status
Reviewed and repaired as part of the shared-service PR sweep. This PR remains unmerged pending GitHub repository gates. No branch-protection bypass or production deployment is included in this review.