Skip to content

fix(deploy): stop MAPLE_ENVIRONMENT being overridable by a stray env var #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Makisuo merged 1 commit into from
Jul 30, 2026
+12 −2
Merged

fix(deploy): stop MAPLE_ENVIRONMENT being overridable by a stray env var #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/alerting/alchemy.run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,13 @@ export const createAlertingWorker = ({ stage, mapleDb, chatFlue }: CreateAlertin
MAPLE_APP_BASE_URL: process.env.MAPLE_APP_BASE_URL?.trim() || "https://app.maple.dev",
EMAIL_FROM: process.env.EMAIL_FROM?.trim() || "Maple <notifications@noreply.maple.dev>",
...optionalPlain("MAPLE_ENDPOINT"),
...optionalPlain("MAPLE_ENVIRONMENT", resolveDeploymentEnvironment(stage)),
// Derived from the stage, deliberately NOT `optionalPlain` — that helper
// lets `process.env` win over the fallback, so a stray
// MAPLE_ENVIRONMENT=production in a pr-N deploy environment would open
// both email gates at once (the worker's scheduled() early-return and
// EmailService.emailAllowed both derive from this one value), leaving
// the prd-only EMAIL binding as the sole guard.
MAPLE_ENVIRONMENT: resolveDeploymentEnvironment(stage),
// Non-prod stages skip all crons (they share live org data via the prod
// DB); set to "1" on a stage to deliberately exercise crons there.
...optionalPlain("MAPLE_ALERTING_ALLOW_NONPROD"),
Expand Down
6 changes: 5 additions & 1 deletion apps/api/alchemy.run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,11 @@ export const createMapleApi = ({ stage, domains }: CreateMapleApiOptions) =>
SERVICE_OPERATIONS_ROLLUP_ENABLED:
process.env.SERVICE_OPERATIONS_ROLLUP_ENABLED?.trim() || "false",
...optionalPlain("MAPLE_ENDPOINT"),
...optionalPlain("MAPLE_ENVIRONMENT", resolveDeploymentEnvironment(stage)),
// Derived from the stage, deliberately NOT `optionalPlain` — that helper
// lets `process.env` win over the fallback, so a stray
// MAPLE_ENVIRONMENT=production in a pr-N deploy environment would open
// EmailService.emailAllowed on a stage that shares live org data.
MAPLE_ENVIRONMENT: resolveDeploymentEnvironment(stage),
...optionalPlain("COMMIT_SHA"),
MAPLE_INGEST_KEY: Redacted.make(requireEnv("MAPLE_OTEL_INGEST_KEY")),
...optionalSecret("MAPLE_ROOT_PASSWORD"),
Expand Down
Loading