fix(query-engine): services filter sidebar now includes all signal types - #288
Closed
robbiemu wants to merge 5 commits into
Closed
fix(query-engine): services filter sidebar now includes all signal types#288robbiemu wants to merge 5 commits into
robbiemu wants to merge 5 commits into
Conversation
robbiemu
marked this pull request as ready for review
July 30, 2026 23:18
Contributor
|
Your Pullfrog Router balance is exhausted. You have a payment method on file but auto-reload is disabled, so runs paused once your balance went past the overdraft buffer. Top up balance → · Enable auto-reload →
|
robbiemu
marked this pull request as draft
July 30, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #285
Problem
The
/servicespage filter sidebar only showed services that have traces (viaservice_overview_spans/service_overview_hourly). Services that only send logs or metrics were missing from the filter dropdown.Solution
Modified
servicesFacetsQuery()inpackages/query-engine/src/ch/queries/services.tsto union service names from all signal tables:service_overview_spans(existing)logs_aggregates_hourly(new)metrics_gauge,metrics_sum,metrics_histogram,metric_catalog(new)service_usage(new)Each branch uses the appropriate table and where conditions for its signal type, following the same UNION ALL pattern as the existing code.
Testing
Design Notes
/traces,/logs,/metrics) continue to use their own signal-specific facet queriesNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.