Skip to content

fix(query-engine): services filter sidebar now includes all signal types - #288

Closed
robbiemu wants to merge 5 commits into
MapleTechLabs:mainfrom
robbiemu:fix/services-filter-all-signals
Closed

fix(query-engine): services filter sidebar now includes all signal types#288
robbiemu wants to merge 5 commits into
MapleTechLabs:mainfrom
robbiemu:fix/services-filter-all-signals

Conversation

@robbiemu

@robbiemu robbiemu commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #285

Problem

The /services page filter sidebar only showed services that have traces (via service_overview_spans / service_overview_hourly). Services that only send logs or metrics were missing from the filter dropdown.

Solution

Modified servicesFacetsQuery() in packages/query-engine/src/ch/queries/services.ts to union service names from all signal tables:

  1. Traces: service_overview_spans (existing)
  2. Logs: logs_aggregates_hourly (new)
  3. Metrics: metrics_gauge, metrics_sum, metrics_histogram, metric_catalog (new)
  4. Aggregated rollup: service_usage (new)

Each branch uses the appropriate table and where conditions for its signal type, following the same UNION ALL pattern as the existing code.

Testing

  • All 16 services tests pass
  • All 647 query-engine tests pass
  • Typecheck passes

Design Notes

  • The Services page is a cross-signal overview — its filter should show all services regardless of signal type
  • Signal-specific pages (/traces, /logs, /metrics) continue to use their own signal-specific facet queries
  • This preserves the existing per-signal filter behavior while fixing the cross-signal overview

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@robbiemu
robbiemu marked this pull request as ready for review July 30, 2026 23:18
@pullfrog

pullfrog Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Your Pullfrog Router balance is exhausted.

You have a payment method on file but auto-reload is disabled, so runs paused once your balance went past the overdraft buffer.

Top up balance → · Enable auto-reload →

Pullfrog  | ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot | Rerun failed job ➔View workflow run | via Pullfrog | Using Claude Opus𝕏

@robbiemu
robbiemu marked this pull request as draft July 30, 2026 23:18
@robbiemu robbiemu closed this Jul 30, 2026
@robbiemu
robbiemu deleted the fix/services-filter-all-signals branch July 30, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service filter omits services with data on the current signal tab

1 participant