fix(local-ui): scope service filters to rendered signals - #295
Draft
robbiemu wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logs, using the same exactTimestampTimeandTimestampbounds as the rendered Logs list.LogsViewand pass it to the list, Service facet, and Severity facet; filter changes and manual refresh advance that shared anchor.useLocalServiceshook.Why
The former shared Service filter was sourced from trace-oriented service overview data, so logs-only services were absent. The first version of this PR moved Logs to
logs_aggregates_hourly, but that was still not exact:The Logs filter now performs an unbounded raw breakdown over the exact page-owned bounds used by
logsListQuery. A service can therefore appear in the filter if and only if at least one raw log for it is renderable in that selected time window.Validation
mainatf74baa90.logs_aggregates_hourlydependency.LIMIT; existing breakdown callers retain their default limit.@maple/local-uiand@maple/query-enginetypechecks passed.git diff --checkpassed (one pre-existing LogsuseEffectwarning remains).This PR intentionally excludes the telemetry-retention work from PR #294. The deployment repository can combine both reviewed changes later.