Change pagefind output to _markbind/logs#2897
Change pagefind output to _markbind/logs#2897yihao03 wants to merge 5 commits intoMarkBind:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2897 +/- ##
========================================
Coverage 71.32% 71.32%
========================================
Files 133 133
Lines 7232 7234 +2
Branches 1714 1612 -102
========================================
+ Hits 5158 5160 +2
- Misses 1973 2068 +95
+ Partials 101 6 -95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
074ca27 to
3e10733
Compare
|
The pagefind indexer doesn't use our default logger, therefore we have to explicitly pass the logsFolder path to it to ensure correct output location |
051ec30 to
8785752
Compare
There was a problem hiding this comment.
Pull request overview
Moves Pagefind’s log output from the project root (debug.log) into MarkBind’s internal logs directory (_markbind/logs/pagefind.log) to keep generated artifacts organized.
Changes:
- Update Pagefind
createIndexoptions to write logs to{root}/_markbind/logs/pagefind.log. - Update unit tests to expect the new logfile path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/core/src/Site/SiteGenerationManager.ts | Changes Pagefind logfile option to _markbind/logs/pagefind.log under the site root. |
| packages/core/test/unit/Site/SiteGenerationManager.test.ts | Adjusts Pagefind createIndex expectations to match the new logfile path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What is the purpose of this pull request?
Overview of changes:
Change pagefind log output from
{projectRoot}/debug.logto{projectRoot}/_markbind/logs/pagefind.logAnything you'd like to highlight/discuss:
Testing instructions:
Pull the branch and run markbind serve to ensure the log file is created at
{projectRoot}/_markbind/logs/pagefind.logand not{projectRoot}/debug.logProposed commit message: (wrap lines at 72 characters)
Move pagefind log output to _markbind/logs/pagefind.log
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):