Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The custom incremental parser and retry behavior require runtime validation beyond static review.
Pull request overview
Reworks block-math parsing into a dedicated module with container-aware content ranges, incremental retry handling, TeX highlighting, and updated previews.
Changes:
- Adds comprehensive math parser and preview tests.
- Moves parser logic into
src/modules/math. - Extracts math preview handling and removes the legacy parser.
File summaries
| File | Description |
|---|---|
CoreEditor/test/math.test.ts |
Adds parser, incremental parsing, highlighting, and preview tests. |
CoreEditor/test/lezer.test.ts |
Removes math tests relocated to the dedicated suite. |
CoreEditor/src/modules/math/index.ts |
Implements the new block-math parser and retry logic. |
CoreEditor/src/styling/nodes/math.ts |
Adds content-aware math preview decorations. |
CoreEditor/src/styling/nodes/code.ts |
Removes math preview code. |
CoreEditor/src/styling/markdown.ts |
Registers the new parser and preview module. |
CoreEditor/src/@vendor/joplin/markdownMathParser.ts |
Removes the superseded implementation. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.