docs(open-pr): watch the regional Cloud Builds, not the global list - #10809
Merged
Conversation
The deploy-app / deploy-api triggers are regional (europe-west4). The skill's post-merge watch ran `gcloud builds list` without --region and got a handful of months-old global builds — all SUCCESS, none from today — which reads like "nothing was triggered" while both deploys were already done; the #10808 follow-through polled that list for 20 minutes. Name the region, add a SHORT_SHA column to match against the merge commit, and record the trap as a gotcha. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016joUzstV3siE3WqJtbcych
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016joUzstV3siE3WqJtbcych
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation updates are consistent with Cloud Build’s regional behavior and include a matching changelog entry, with no functional code changes introduced.
Pull request overview
This PR updates the open-pr skill documentation to correctly monitor regional Cloud Build triggers (europe-west4) after merge, avoiding the misleading results from the global gcloud builds list output, and records the rationale so the trap is not repeated.
Changes:
- Update the post-merge deploy watch command to use
gcloud builds list --region=europe-west4and include aSHORT_SHAcolumn for matching the merge commit. - Add an explicit explanatory note in the skill doc about why
--regionis required fordeploy-app/deploy-api. - Add a
[Unreleased]changelog entry under Changed describing the fix and the incident that prompted it.
File summaries
| File | Description |
|---|---|
CHANGELOG.md |
Adds an Unreleased “Changed” entry documenting the regional Cloud Build watch fix for open-pr. |
.claude/skills/open-pr/SKILL.md |
Updates the deploy-watch commands to use the europe-west4 region and documents the rationale + SHORT_SHA verification tip. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open-prskill's §4 post-merge deploy watch rangcloud builds listwithout--region=europe-west4. Thedeploy-app/deploy-apitriggers are regional, so the global list answers with months-old builds — allSUCCESS, none from today — which reads like "nothing was triggered" while both deploys are already done. The feat: LLM discoverability sync from kurrentschrift #10808 follow-through polled that list for 20 minutes before noticing.SHORT_SHAcolumn to match against the merge commit, and the trap is recorded next to the command. Changelog entry under Changed.Plan
N/A — friction found during the #10808 follow-through.
Test plan
gcloud builds list --region=europe-west4 --limit 3 --format=…run as written: showsdeploy-appanddeploy-apifor87f78ad(the feat: LLM discoverability sync from kurrentschrift #10808 merge), bothSUCCESS; the global form shows three April builds