Skip to content

refactor(seo): import display-name maps from core.constants - #12419

Merged
MarkusNeusinger merged 4 commits into
mainfrom
fix/9636-seo-shared-name-maps-7833155130236717733
Oct 29, 2026
Merged

MarkusNeusinger merged 4 commits into
mainfrom
fix/9636-seo-shared-name-maps-7833155130236717733

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Closes #9636


PR created automatically by Jules for task 7833155130236717733 started by @MarkusNeusinger

@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes reuse canonical shared mappings and add tests covering map identity and registry coverage, with no active review issues identified.

No open issues 🎉

What changed in this PR

This pull request removes duplicated SEO display-name maps by reusing the canonical mappings from core.constants, keeping SEO output consistent with the shared registry.

Changes:

  • Imports and uses shared LANGUAGE_NAMES and LIBRARY_NAMES mappings.
  • Updates tests to verify registry coverage and map identity.
  • Adds a changelog entry documenting the refactor.
File Description
tests/​unit/​api/​test_seo_helpers.py Verifies canonical map usage, identity, and registry coverage.
changelog.d/​seo-shared-name-maps.md Documents the shared-map refactor.
api/​routers/​seo.py Replaces locally derived display-name maps with shared constants.

Review effort: Lite

@MarkusNeusinger
MarkusNeusinger merged commit c2d20eb into main Oct 29, 2026
15 checks passed
@MarkusNeusinger
MarkusNeusinger deleted the fix/9636-seo-shared-name-maps-7833155130236717733 branch October 29, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-up: seo.py display names from core.constants (after #9621/#9624 merge)

2 participants