Repository navigation
refactor(seo): import display-name maps from core.constants - #12419
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
🟢 Approval recommended
The changes reuse canonical shared mappings and add tests covering map identity and registry coverage, with no active review issues identified.
No open issues 🎉
What changed in this PR
This pull request removes duplicated SEO display-name maps by reusing the canonical mappings from core.constants, keeping SEO output consistent with the shared registry.
Changes:
- Imports and uses shared
LANGUAGE_NAMESandLIBRARY_NAMESmappings. - Updates tests to verify registry coverage and map identity.
- Adds a changelog entry documenting the refactor.
| File | Description |
|---|---|
tests/unit/api/test_seo_helpers.py |
Verifies canonical map usage, identity, and registry coverage. |
changelog.d/seo-shared-name-maps.md |
Documents the shared-map refactor. |
api/routers/seo.py |
Replaces locally derived display-name maps with shared constants. |
Review effort: Lite
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes #9636
PR created automatically by Jules for task 7833155130236717733 started by @MarkusNeusinger